sync: build for wasm - #14769

Open

oech3 wants to merge 1 commit into

uutils:mainfrom

oech3:sync-wasi

oech3 commented Sep 21, 2026

Contributor

Syncing a file seems possible on wasip at least for.

github-actions Bot commented Sep 21, 2026 •

edited

Loading

GNU testsuite comparison:

Skipping an intermittent issue tests/date/resolution (passes in this run but fails in the 'main' branch)

sylvestre reviewed

View reviewed changes

src/uu/sync/src/sync.rs Outdated

sylvestre reviewed

View reviewed changes

src/uu/sync/src/sync.rs Outdated

sylvestre reviewed

View reviewed changes

src/uu/sync/src/sync.rs

sylvestre reviewed

View reviewed changes

Cargo.toml Outdated

oech3 force-pushed the sync-wasi branch 9 times, most recently from 0a75721 to 4e15855 Compare

September 21, 2026 17:04

sylvestre reviewed

View reviewed changes

src/uu/sync/src/sync.rs Outdated

sylvestre reviewed

View reviewed changes

src/uu/sync/src/sync.rs

sylvestre reviewed

View reviewed changes

src/uu/sync/src/sync.rs Outdated

sylvestre reviewed

View reviewed changes

src/uu/sync/src/sync.rs Outdated

sylvestre reviewed

View reviewed changes

src/uu/sync/src/sync.rs

oech3 force-pushed the sync-wasi branch 3 times, most recently from ffa6449 to 196bd97 Compare

September 22, 2026 05:36

oech3 commented Sep 22, 2026

Contributor Author

It seems std::fs::File::sync_fata is fdatasync. Should we drop rustix::fs::fdatasync?

oech3 force-pushed the sync-wasi branch 2 times, most recently from 1e2c389 to 0dade4f Compare

September 22, 2026 07:46

oech3 commented Sep 22, 2026

Contributor Author

Permission denied on Windows...

oech3 force-pushed the sync-wasi branch 4 times, most recently from 469590d to d320767 Compare

September 23, 2026 01:02

oech3 force-pushed the sync-wasi branch 2 times, most recently from d994446 to 15b97ad Compare

September 23, 2026 01:04


          sync: build for wasm

dfd1264

oech3 force-pushed the sync-wasi branch from 15b97ad to dfd1264 Compare

September 23, 2026 01:22

codspeed Bot commented Sep 23, 2026 •

edited

Loading

Merging this PR will improve performance by 31.19%

⚠️

Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 3 improved benchmarks
✅ 386 untouched benchmarks
⏩ 54 skipped benchmarks¹

Performance Changes

	Mode	Benchmark	`BASE`	`HEAD`	Efficiency
⚡	Simulation	`three_39_bit_primes`	989.8 ms	641.1 ms	+54.39%
⚡	Simulation	`complex_relative_date`	400.3 µs	288.3 µs	+38.82%
⚡	Simulation	`five_38_bit_primes`	1.8 s	1.7 s	+5.34%

Tip

Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.

_{Comparing oech3:sync-wasi (dfd1264) with main (f38db6d)}

54 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

oech3 requested a review from sylvestre

September 23, 2026 02:16

This branch has not been deployed

No deployments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet