Skip to content

[perf] split: reuse the per-line buffer in round-robin mode #14790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sylvestre merged 1 commit into from
Sep 22, 2026
+3 −2
Merged

[perf] split: reuse the per-line buffer in round-robin mode #14790

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/uu/split/src/split.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1234,9 +1234,10 @@ fn n_chunks_by_line_round_robin(
let mut closed_writers = 0;

let mut i = 0;
let mut line = Vec::new();

@sylvestre sylvestre Sep 22, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you please add a bench for the r/N mode in benches/split_bench.rs? otherwise codspeed won't track this gain

loop {
let line = &mut Vec::new();
let num_bytes_read = reader.by_ref().read_until(sep, line)?;
line.clear();
let num_bytes_read = reader.by_ref().read_until(sep, &mut line)?;

// if there is nothing else to read - exit the loop
if num_bytes_read == 0 {
Expand Down
Loading