[INTW26] Build Interview Delegation Algorithm + Interview Group CRUD Endpoints - #127
Merged
mxc-maggiechen merged 3 commits intoMay 11, 2026
Merged
Conversation
chene0
force-pushed
the
INTW26-build-interview-delegation-algorithm
branch
from
March 17, 2026 01:31
1e87ecb to
88f872a
Compare
chene0
force-pushed
the
INTW26-build-interview-delegation-algorithm
branch
2 times, most recently
from
March 28, 2026 23:36
b2b75ac to
8bce34f
Compare
chene0
commented
Mar 31, 2026
SaqAsh
requested changes
Apr 1, 2026
SaqAsh
left a comment
Collaborator
There was a problem hiding this comment.
I am gonna write up something that cleans a lot of the interviewDashboardService.ts I think @mxc-maggiechen let me know if you like my suggestion better gotta prompt claude to write something that is cleaner for you :)
| }) | ||
| ).reduce((map, user) => { | ||
| // eslint-disable-next-line @typescript-eslint/no-non-null-assertion | ||
| const pos = user.position!; |
Collaborator
There was a problem hiding this comment.
maybe broken type here we don't want to do that
| }); | ||
|
|
||
| interviewedApplicantRecords.forEach((record) => { | ||
| /* eslint-disable @typescript-eslint/no-non-null-assertion */ |
| arr.push(user.id); | ||
| map.set(pos, arr); | ||
| return map; | ||
| }, new Map<string, number[]>()); |
Collaborator
There was a problem hiding this comment.
generally, native Map type in javascript is just harder to work with, I prefer using a Record<T,V>
| }, new Map<string, number[]>()); | ||
|
|
||
| // 1. build the FSM | ||
| const FSM = new Map<string, [number, (number | undefined)[]]>( |
Collaborator
There was a problem hiding this comment.
uhh I don't know too much about this type... I think maybe we can do something like defining the (number | undefined)[] as a type or sumn to give it semantic meaning
| } | ||
| if (userIds.length % 2 !== 0) { | ||
| // sentinel value of undefined at the end | ||
| userIds.push(undefined); |
SaqAsh
reviewed
Apr 1, 2026
SaqAsh
reviewed
Apr 1, 2026
SaqAsh
reviewed
Apr 1, 2026
SaqAsh
approved these changes
Apr 3, 2026
4 tasks
SaqAsh
requested changes
Apr 19, 2026
mxc-maggiechen
force-pushed
the
INTW26-build-interview-delegation-algorithm
branch
from
May 11, 2026 03:12
1ae9992 to
1da583f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notion ticket link
Build Interview Delegation Algorithm
Implementation description
Steps to test
Interview Group CRUD
docker compose upinterview_groupstable content makes sense after each queryDelegation Algorithm
docker compose upWhat should reviewers focus on?
Interview Group CRUD
schedulingLinkschedulingLink, the row'sschedulingLinkvalue should not changeChecklist