Skip to content

Feature/customabble pdf bar button icon #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Feature/customabble pdf bar button icon #78

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8eb7cbd
splist PDFBarButton-generate method
abeyuya Nov 28, 2017
f1a6f94
change share and thumb image to accessable
abeyuya Nov 28, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 31 additions & 14 deletions Pod/Classes/Renderer/PDFViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,12 @@ open class PDFViewController: UIViewController {
/// A reference to the share button
var shareBarButtonItem: UIBarButtonItem?

/// The share button icon
open lazy var shareBarButtonIcon: UIImage? = UIImage.bundledImage("share")

/// The thumbs button icon
open lazy var thumbsBarButtonIcon: UIImage? = UIImage.bundledImage("thumbs")

/// A closure that defines an action to take upon selecting the share button.
/// The default action brings up a UIActivityViewController
open lazy var shareBarButtonAction: () -> () = { self.showActivitySheet() }
Expand Down Expand Up @@ -197,24 +203,13 @@ open class PDFViewController: UIViewController {
var buttons: [UIBarButtonItem] = []

if allowsSharing {

let shareFormBarButtonItem = PDFBarButton(
image: UIImage.bundledImage("share"),
toggled: false,
target: self,
action: #selector(PDFViewController.shareDocument)
)
let shareFormBarButtonItem = buildShareFormBarButtonItem()
buttons.append(shareFormBarButtonItem)
self.shareBarButtonItem = shareFormBarButtonItem
}

buttons.append(PDFBarButton(
image: UIImage.bundledImage("thumbs"),
toggled: false,
target: self,
action: #selector(PDFViewController.showThumbnailView)
)
)
let thumbsBarButtonItem = buildThumbsBarButtonItem()
buttons.append(thumbsBarButtonItem)


if allowsAnnotations {
Expand All @@ -237,6 +232,28 @@ open class PDFViewController: UIViewController {
return buttons
}

private func buildShareFormBarButtonItem() -> PDFBarButton {
let shareFormBarButtonItem = PDFBarButton(
image: shareBarButtonIcon,
toggled: false,
target: self,
action: #selector(PDFViewController.shareDocument)
)

return shareFormBarButtonItem
}

private func buildThumbsBarButtonItem() -> PDFBarButton {
let thumbsBarButtonItem = PDFBarButton(
image: thumbsBarButtonIcon,
toggled: false,
target: self,
action: #selector(PDFViewController.showThumbnailView)
)

return thumbsBarButtonItem
}

func toggleAnnotations(_ button: PDFBarButton) {
showingAnnotations = !showingAnnotations
reloadBarButtons()
Expand Down