Skip to content

Minor fixes for server.py #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cbbayburt merged 3 commits into from
Dec 11, 2025
Merged

Minor fixes for server.py #37

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d7b90c3
Consider UYUNI_MCP_SSL_VERIFY rather than hardcoding to false
renner Dec 3, 2025
bbd6888
Fix typos in docstrings and comments
renner Dec 3, 2025
a8041b3
get_unscheduled_errata(): tool registration
renner Dec 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions src/mcp_server_uyuni/server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1070,7 +1070,7 @@ async def add_system(
payload["proxyId"] = proxy_id
logger.info(f"adding system {host}")

async with httpx.AsyncClient(verify=False) as client:
async with httpx.AsyncClient(verify=CONFIG["UYUNI_MCP_SSL_VERIFY"]) as client:
api_result = await call_uyuni_api(
client=client, method="POST",
api_path="/rhn/manager/api/system/bootstrapWithPrivateSshKey",
Expand Down Expand Up @@ -1139,7 +1139,7 @@ async def remove_system(system_identifier: Union[str, int], ctx: Context, cleanu

cleanup_type = "FORCE_DELETE" if cleanup else "NO_CLEANUP"

async with httpx.AsyncClient(verify=False) as client:
async with httpx.AsyncClient(verify=CONFIG["UYUNI_MCP_SSL_VERIFY"]) as client:
api_result = await call_uyuni_api(
client=client,
method="POST",
Expand Down Expand Up @@ -1486,7 +1486,7 @@ async def list_activation_keys(ctx: Context) -> List[Dict[str, str]]:
"""
list_keys_path = '/rhn/manager/api/activationkey/listActivationKeys'

async with httpx.AsyncClient(verify=False) as client:
async with httpx.AsyncClient(verify=CONFIG["UYUNI_MCP_SSL_VERIFY"]) as client:
api_result = await call_uyuni_api(
client=client,
method="GET",
Expand All @@ -1506,25 +1506,26 @@ async def list_activation_keys(ctx: Context) -> List[Dict[str, str]]:
await ctx.warning(msg)
return filtered_keys

@mcp.tool()
async def get_unscheduled_errata(system_id: int, ctx: Context) -> List[Dict[str, Any]]:
"""
Provides a list of errata that are applicable to the system with the system_id
passed as parameter and have not ben scheduled yet. All elements in the result are patches that are applicable
passed as parameter and have not been scheduled yet. All elements in the result are patches that are applicable
for the system.

Args:
sid: The integer ID of the system for which we want to know the list of applicable errata.
system_id: The integer ID of the system for which we want to know the list of applicable errata.

Returns:
List[Dict[str, Any]]: A list of dictionaries with each dictionary defining a errata applicable
to the system given as a parameter.
Retruns an empty dictionary if no applicable errata for the system are found.
Returns an empty dictionary if no applicable errata for the system are found.
"""
log_string = f"Getting list of unscheduled errata for system {system_id}"
logger.info(log_string)
await ctx.info(log_string)

async with httpx.AsyncClient(verify=False) as client:
async with httpx.AsyncClient(verify=CONFIG["UYUNI_MCP_SSL_VERIFY"]) as client:
get_unscheduled_errata = "/rhn/manager/api/system/getUnscheduledErrata"
payload = {'sid': str(system_id)}
unscheduled_errata_result = await call_uyuni_api(
Expand Down Expand Up @@ -1558,5 +1559,5 @@ def main_cli():
mcp.run(transport="stdio")
else:
# Defaults to stdio transport anyway
# But I explicitety state it here for clarity
# But I explicitly state it here for clarity
mcp.run(transport="stdio")