RFC: Enhanced Ansible support #98
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pascal Arlt <[email protected]>
parlt91
requested review from
cbbayburt,
rjmateus,
Etheryte,
meaksh,
admd,
bisht-richa and
wweellddeerr
rjmateus
reviewed
Dec 10, 2024
Etheryte
reviewed
Dec 11, 2024
admd
reviewed
Dec 11, 2024
admd
reviewed
Dec 11, 2024
meaksh
reviewed
Dec 12, 2024
cbbayburt
approved these changes
Dec 16, 2024
There was a problem hiding this comment.
Thanks, @parlt91. Looks good to me. All my concerns are already discussed under other reviews.
Here's a couple of remarks:
-
I think it's important that users have the exact list of the clients on which the playbook is executed. IIUC we'll store this in action details. This should be a hard requirement.
-
We should explore the formulas with forms UI to reuse as much as we can. Formulas UI also uses yaml to define the forms, so there's some opportunity there.
parlt91
force-pushed
the
enhanced-ansible-support
branch
from
7826c48 to
a09b412
Compare
meaksh
reviewed
Dec 17, 2024
Signed-off-by: Pascal Arlt <[email protected]>
parlt91
force-pushed
the
enhanced-ansible-support
branch
from
a09b412 to
ac56a48
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This RFC describes planned enhancements to the existing Ansible implementation in Uyuni
See the rendered version.