Update uyuni_roster.conf when running spacewalk-hostname-rename#11456
Open
Update uyuni_roster.conf when running spacewalk-hostname-rename#11456
Conversation
cbosdo
reviewed
Feb 10, 2026
Contributor
cbosdo
left a comment
There was a problem hiding this comment.
You need to add a changelog entry, but the change looks good to me. Thanks for the fishx
aaannz
reviewed
Feb 17, 2026
Contributor
aaannz
left a comment
There was a problem hiding this comment.
I am not sure this is safe.
Imagine scenario people have multiple services on one host, like gitfs or what not which salt can be configured to use.
Then decide to move a uyuni server somewhere else and keep the rest.
With this you modify all salt configuration data, even though some of them should be kept as is.
I think modifying just uyuni_roster.conf is preferable.
c8f0ddc to
ca6bb53
Compare
638e9a2 to
fdc5459
Compare
Member
Author
|
I tested it changing from oscar-server to oscar-proxy my server hostname. |
mbussolotto
reviewed
Feb 25, 2026
Member
mbussolotto
left a comment
There was a problem hiding this comment.
please add changelog, the other changes are fine
Add functionality to update Salt Master configuration files with new hostname.
fdc5459 to
7b6274a
Compare
mbussolotto
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR change?
Add functionality to update
uyuni_roster.conf, on the Salt Master configuration, with new hostname.GUI diff
No difference.
Documentation
No documentation needed
DONE
Test coverage
ℹ️ If a major new functionality is added, it is strongly recommended that tests for the new functionality are added to the Cucumber test suite
No tests
DONE
Links
Issue(s): https://bugzilla.suse.com/show_bug.cgi?id=1257694
Port(s):
Manager-5.1
DONE
Changelogs
Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository
If you don't need a changelog check, please mark this checkbox:
If you uncheck the checkbox after the PR is created, you will need to re-run
changelog_test(see below)Re-run a test
If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:
Before you merge
Check How to branch and merge properly!