-
Notifications
You must be signed in to change notification settings - Fork 209
chore: Upgrade supported Node.js to 20 #4257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v24
Are you sure you want to change the base?
Conversation
Node.js goes out of support and React 19 needs Node.js 20+
@@ -17,7 +17,7 @@ This page shows the minimum required versions of supported technologies for Vaad | |||
|
|||
| Java| 17 or later | |||
| Spring Boot| 3.0 or later | |||
| Node.js| 18 or later | |||
| Node.js| 20 or later |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to be a 24.0 list and now you are changing only one part of it but still linking to 24.0.0 release notes above. It should be made clearer that this is for the latest minor of Vaadin 24, link to that and also update all the other rows from 24.7.0 release notes
Is this PR still relevant? |
Yes, still relevant, Vaadin 24.7+ (latest supported minor versions) are all have Node.js 20 as a minimum supported. It was abandoned by me in favour of other tasks, but need still to figure out how this article is aligned with the release notes and how to address Artur's comment above. |
@mshabarov Understood. If you want this change to show up in the |
Yes, I don't even remember why haven't I chosen the |
@mshabarov Probably because the |
Node.js goes out of support and React 19 needs Node.js 20+