refactor: import TextField class from @vaadin/text-field #7102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vursen
commented
Feb 7, 2025
| :host { | ||
| width: 8em; | ||
| } | ||
| class BigDecimalField extends TextField { |
There was a problem hiding this comment.
note: Renamed BigDecimalFieldElement to BigDecimalField to better align with the naming conventions we use in web components
web-padawan
reviewed
Feb 7, 2025
...n-text-field-flow/src/main/resources/META-INF/resources/frontend/vaadin-big-decimal-field.js
Outdated
Show resolved
Hide resolved
|
web-padawan
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PR refactors the
vaadin-big-decimal-fieldweb component to import the TextField class from@vaadin/text-fieldinstead of usingcustomElements.get.Type of change