fix: add viewport-fix=cover to index.html as well #20943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vursen
changed the title
|
mshabarov
approved these changes
Feb 3, 2025
vaadin-bot
pushed a commit
that referenced
this pull request
Feb 3, 2025
It turns out that viewport-fix=cover also needs to be added to index.html, in addition to @Viewport annotations, which were addressed in #20836. Fixes vaadin/web-components#8449
vaadin-bot
added a commit
that referenced
this pull request
Feb 3, 2025
It turns out that viewport-fix=cover also needs to be added to index.html, in addition to @Viewport annotations, which were addressed in #20836. Fixes vaadin/web-components#8449 Co-authored-by: Sergey Vinogradov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It turns out that
viewport-fix=coveralso needs to be added toindex.html, in addition to@Viewportannotations, which were addressed in #20836.Fixes vaadin/web-components#8449
Type of change