test: add visual regression tests #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-padawan
force-pushed
the
visual-tests
branch
2 times, most recently
from
582fa62 to
49fc4a4
Compare
web-padawan
force-pushed
the
visual-tests
branch
from
0e2424b to
6872572
Compare
sosa-vaadin
reviewed
Mar 18, 2021
packages/vaadin-ordered-layout/test/visual/lumo/horizontal-layout.test.js
Show resolved
Hide resolved
sosa-vaadin
reviewed
Mar 18, 2021
sosa-vaadin
reviewed
Mar 18, 2021
packages/vaadin-ordered-layout/test/visual/material/horizontal-layout.test.js
Show resolved
Hide resolved
sosa-vaadin
reviewed
Mar 18, 2021
packages/vaadin-ordered-layout/test/visual/material/vertical-layout.test.js
Show resolved
Hide resolved
sosa-vaadin
approved these changes
Mar 19, 2021
|
There are no visual tests for disabled tabs but we can leave that for another time. |
|
@sosa-vaadin Good point, thanks. I submitted an issue #173 with a few more missing tests, will add those later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #67