feat: type event target for upload events #8627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
There is a ticket about this issue: #7868. Should we consider applying this approach to all components? |
I'd say yes, but I think it's fine to do this in smaller chunks. This is inspired by a practical use case that came up in Slack, so I spent a few minutes on adding it for upload. |
vursen
approved these changes
Feb 4, 2025
|
This ticket/PR has been released with Vaadin 24.7.0.alpha10 and is also targeting the upcoming stable 24.7.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Types
event.targetfor upload events, so that casting the target is unnecessary when trying to use the upload element in event handlers. This could be used for example to clear the files when an upload has finished usingevent.target.files = [].Part of #7868
Type of change