Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add missing nextResize #8635

Merged
merged 1 commit into from
Feb 4, 2025
Merged

test: add missing nextResize #8635

merged 1 commit into from
Feb 4, 2025

Conversation

vursen
Copy link
Contributor

@vursen vursen commented Feb 4, 2025

Description

Fixes the following test failures that were introduced in #8633:

packages/form-layout/test/form-layout-lit.generated.test.js:

 ❌ form layout > hidden > should update steps on show after hidden
      AssertionError: expected _selectResponsiveStep to have been called exactly once, but it was called 0 times
        at n.<anonymous> (packages/form-layout/test/form-layout-lit.generated.test.js:444:24)


packages/form-layout/test/form-layout.test.js:

 ❌ form layout > hidden > should update steps on show after hidden
      AssertionError: expected _selectResponsiveStep to have been called exactly once, but it was called 0 times
        at n.<anonymous> (packages/form-layout/test/form-layout.test.js:444:24)

Type of change

  • Internal

@vursen vursen requested a review from DiegoCardoso February 4, 2025 14:08
Copy link

sonarqubecloud bot commented Feb 4, 2025

@vursen vursen merged commit a7890f5 into main Feb 4, 2025
9 checks passed
@vursen vursen deleted the add-missing-next-resize branch February 4, 2025 14:12
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.7.0.alpha10 and is also targeting the upcoming stable 24.7.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants