test: switch from puppeteer to playwright chrome #8659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vursen
changed the title
vursen
force-pushed
the
switch-to-playwright-chrome
branch
from
585bf90 to
ac08a9b
Compare
web-padawan
reviewed
Feb 10, 2025
web-padawan
approved these changes
Feb 10, 2025
|
sissbruecker
approved these changes
Feb 10, 2025
vursen
commented
Feb 10, 2025
| @@ -61,6 +61,12 @@ describe('active-mixin', () => { | |||
| }); | |||
|
|
|||
| describe('keyboard', () => { | |||
| afterEach(async () => { | |||
| for (const key of ['Space', 'Enter']) { | |||
There was a problem hiding this comment.
note: This should stabilize the following test in Firefox, which has become flaky, presumably after upgrading Playwright to version 1.50:
packages/a11y-base/test/active-mixin.test.js:
❌ The browser was unable to create and start a test page after 60000ms. You can increase this timeout with the browserStartTimeout option.
vaadin-bot
pushed a commit
that referenced
this pull request
Feb 10, 2025
vaadin-bot
pushed a commit
that referenced
this pull request
Feb 10, 2025
web-padawan
pushed a commit
that referenced
this pull request
Feb 10, 2025
Co-authored-by: Sergey Vinogradov <[email protected]>
web-padawan
pushed a commit
that referenced
this pull request
Feb 10, 2025
Co-authored-by: Sergey Vinogradov <[email protected]>
|
This ticket/PR has been released with Vaadin 24.7.0.alpha10 and is also targeting the upcoming stable 24.7.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PR updates the test setup to use Playwright Chrome instead of Puppeteer, which allows us to dispose of
sendKeysandresetMouseextensions. Playwright natively supports key modifier shortcuts and doesn't have the mouse-related issue that occurred in Puppeteer.Type of change