Skip to content
Closed
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
9 changes: 6 additions & 3 deletions packages/upload/theme/lumo/vaadin-upload-styles.js
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,7 @@ const uploadFile = css`
[part='commands'] {
display: flex;
align-items: baseline;
align-self: flex-start;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should just change it to use align-items: flex-start everywhere. Using baseline as a default doesn't seem particularly useful for the elements that the upload file row contains.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It occurred to me that the whole row would be better implemented as a css grid... which we could definitely do in V25, and possibly in a minor.

flex: none;
}

Expand All @@ -131,6 +132,7 @@ const uploadFile = css`
font-size: var(--lumo-icon-size-m);
font-family: 'lumo-icons';
line-height: 1;
align-self: flex-start;
}

/* When both icons are hidden, let us keep space for one */
Expand All @@ -151,9 +153,10 @@ const uploadFile = css`
box-shadow: 0 0 0 var(--_focus-ring-width) var(--_focus-ring-color);
}

[part$='icon']::before,
[part$='button']::before {
vertical-align: -0.25em;
/* Vertically align icons / buttons with the first line of text */
[part$='icon'],
[part$='button'] {
margin-top: calc((1em * var(--lumo-line-height-m) - var(--lumo-icon-size-m)) / 2);
}

[part='done-icon']::before {
Expand Down