Skip to content

experiment: App Layout base styles #9269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

experiment: App Layout base styles #9269

wants to merge 5 commits into from

Conversation

jouni
Copy link
Member

@jouni jouni commented May 22, 2025

Supported custom properties

Property Description
--vaadin-app-layout-drawer-background Background of the drawer.
--vaadin-app-layout-drawer-width Width of the drawer.
--vaadin-app-layout-touch-optimized Flag that triggers the bottom-aligned navbar.
--vaadin-overlay-backdrop-background Background of the drawer backdrop. Shared across all overlays.
--vaadin-overlay-box-shadow Shadow of the drawer. Shared across all overlays.
--vaadin-app-layout-navbar-background Background of the navbar.
--vaadin-app-layout-transition-duration Transition duration for the drawer open and close animation.

I consider the following properties private and read only. I would consider refactoring their implementation before Vaadin 25.0.

Property
--vaadin-app-layout-navbar-offset-top
--vaadin-app-layout-navbar-offset-bottom
--vaadin-app-layout-navbar-offset-left
--vaadin-app-layout-drawer-offset-left

The --vaadin-app-layout-navbar-offset-left property seems to be completely useless, it's always zero.

@jouni
Copy link
Member Author

jouni commented May 22, 2025

@vursen, note that these components don't need the base layer reset in the Lumo theme. I already included all necessary overrides in them, as the changes from the core styles to the new base styles weren't that big.

@jouni jouni force-pushed the base-app-layout branch from f31b35b to 7d1da78 Compare May 22, 2025 20:31
Copy link

@jouni jouni changed the title experiment!: App Layout base styles experiment: App Layout base styles May 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant