Improved code #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nice project @varunherlekar. Still, there are some improvements which I've made. Some codes were ambiguous like importing unnecessary modules and print statements. Also, you can add some more functionality like if the user needs numbers or alphabets or other signs. It will be hard for the user itself to remember the password rather than a hacker to crack it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nice project @varunherlekar. Still, there are some improvements which I've made. Some codes were ambiguous like importing unnecessary modules and print statements.
Also, you can add some more functionality like if the user needs numbers or alphabets or other signs. It will be hard for the user itself to remember the password rather than a hacker to crack it.