fix(stream): synchronize write #116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladopajic
commented
Sep 11, 2025
arnetheduck
reviewed
Sep 12, 2025
quic/transport/semaphore.nim
Outdated
| logScope: | ||
| topics = "libp2p semaphore" | ||
|
|
||
| type AsyncSemaphore* = ref object of RootObj |
There was a problem hiding this comment.
it would be better to upstream AsyncSemaphore to chronos instead of copy-pasting it into each project
There was a problem hiding this comment.
there are also some tests here that can be recycled: status-im/nim-chronos#147
gmelodie
approved these changes
Sep 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes vacp2p/nim-libp2p#1603