Skip to content

Add FIMM and FM FIRs#211

Merged
JYang365 merged 14 commits intomainfrom
add-FI
Mar 18, 2026
Merged

Add FIMM and FM FIRs#211
JYang365 merged 14 commits intomainfrom
add-FI

Conversation

@JYang365
Copy link
Copy Markdown
Contributor

@JYang365 JYang365 commented Mar 17, 2026

image image image image

@JYang365 JYang365 changed the title Add FIMM FIR Add FIMM and FM FIRs Mar 17, 2026
@JYang365 JYang365 marked this pull request as ready for review March 18, 2026 00:17
@JYang365 JYang365 requested review from a team as code owners March 18, 2026 00:17
Copy link
Copy Markdown
Member

@MorpheusXAUT MorpheusXAUT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just out of curiosity - why is FIMM not FI? Is there other FI stations controlled by someone else?

@@ -0,0 +1,48 @@
[[positions]]
id = "FIMM_FSS"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#209 is defining FIMM_FSS as well, although that might be in error, as per PR comments. Please coordinate with them on who defines the stations/positions, if necessary (e.g., shared control)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MorpheusXAUT Thanks, should be us that define it as they do not cover it at all. Will talk..

@JYang365
Copy link
Copy Markdown
Contributor Author

Just out of curiosity - why is FIMM not FI? Is there other FI stations controlled by someone else?

I did it because of 'FJDG' and airport within the FIR however starts with FJ

@MorpheusXAUT
Copy link
Copy Markdown
Member

Just out of curiosity - why is FIMM not FI? Is there other FI stations controlled by someone else?

I did it because of 'FJDG' and airport within the FIR however starts with FJ

Got it 👍

@MorpheusXAUT
Copy link
Copy Markdown
Member

Can you do me a favour and add the entry in the CODEOWNERS file as well, if it's something that's owned by VATSSA (or something else that already exists)? Saves me having to create an extra PR every time 😁 You can just check how the rest is done in .github/CODEOWNERS and add a new line (in alphabetical order, please).
If we need a new group, I'll create it and add the codeowners entry myself.

Copy link
Copy Markdown
Member

@MorpheusXAUT MorpheusXAUT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^See above - codeowners entry, please 🙏

@JYang365
Copy link
Copy Markdown
Contributor Author

Can you do me a favour and add the entry in the CODEOWNERS file as well, if it's something that's owned by VATSSA (or something else that already exists)? Saves me having to create an extra PR every time 😁 You can just check how the rest is done in .github/CODEOWNERS and add a new line (in alphabetical order, please). If we need a new group, I'll create it and add the codeowners entry myself.

Yeah, will do that now alongside every other PR. Was thinking that it would be easier! :)

@JYang365 JYang365 requested a review from MorpheusXAUT March 18, 2026 08:28
@JYang365
Copy link
Copy Markdown
Contributor Author

Also added FM now, forgot about that the first commit 😆

@MorpheusXAUT
Copy link
Copy Markdown
Member

Also added FM now, forgot about that the first commit 😆

Thanks, looks good 👍

@JYang365 JYang365 merged commit 8ceafdf into main Mar 18, 2026
6 checks passed
@JYang365 JYang365 deleted the add-FI branch March 18, 2026 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants