Skip to content

Remove RCAA definitions from VHHK dataset#373

Merged
Syntax505 merged 5 commits intomainfrom
vhhk-remove-tpe-definitions
May 6, 2026
Merged

Remove RCAA definitions from VHHK dataset#373
Syntax505 merged 5 commits intomainfrom
vhhk-remove-tpe-definitions

Conversation

@Syntax505
Copy link
Copy Markdown
Contributor

@Syntax505 Syntax505 commented May 3, 2026

Description

Removed RCAA definitions from VHHK dataset as per #363. Not to be merged until #363 has been merged.

Checklist

  • Dataset files are in the correct dataset/{FIR}/ directory.
  • I have verified the data is correct.
  • If adding a new FIR: CODEOWNERS entry added and maintainer team noted in PR description.
  • If contributing from a fork: "Allow edits by maintainers" is enabled.

@Syntax505 Syntax505 requested a review from a team as a code owner May 3, 2026 09:51
@Syntax505 Syntax505 marked this pull request as draft May 3, 2026 09:53
@Syntax505 Syntax505 changed the title Remove RCAA definitions Remove RCAA definitions from VHHK dataset May 3, 2026
@Syntax505 Syntax505 marked this pull request as ready for review May 4, 2026 07:47
@Syntax505
Copy link
Copy Markdown
Contributor Author

@vacs-project/core-maintainers Perhaps I am being a bit thick here, but I'm not quite sure why the checks are failing. It says that the referenced station ID TPE_W_CTR doesn't exist, but clearly that is defined within dataset/RCAA/positions.json. Is it because this PR was created before #363 was merged?

@MorpheusXAUT MorpheusXAUT force-pushed the vhhk-remove-tpe-definitions branch from 7aa4e61 to 4a8b401 Compare May 4, 2026 08:05
@MorpheusXAUT
Copy link
Copy Markdown
Member

@vacs-project/core-maintainers Perhaps I am being a bit thick here, but I'm not quite sure why the checks are failing. It says that the referenced station ID TPE_W_CTR doesn't exist, but clearly that is defined within dataset/RCAA/positions.json. Is it because this PR was created before #363 was merged?

Position TPE_W_CTR exists, but the station TPE_W_CTR does not. There is a AWR station covered by the position.

@Syntax505
Copy link
Copy Markdown
Contributor Author

Ah! I see. Sorry - this is what happens when I work on PRs on a Monday morning. Let me fix that now.

@Syntax505 Syntax505 merged commit 23e10ff into main May 6, 2026
7 checks passed
@Syntax505 Syntax505 deleted the vhhk-remove-tpe-definitions branch May 6, 2026 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants