feat: introduce request forwarder abstraction and security improvements #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 13 commits
February 1, 2025 00:18
- Add --proxy flag to specify upstream proxy - Implement proxy forwarding in ProxyForwarder - Fix request body handling with ByteStreamBody - Clean up and simplify proxy implementation - Add basic tests for proxy forwarding
- Add hyper-tls dependency for HTTPS support - Configure HttpsConnector for TLS connections - Preserve original scheme when rewriting requests - Clean up imports and dependencies
- Add --insecure flag to skip TLS verification for self-signed certs - Update ProxyForwarder to use HttpsConnector for proxy connections - Add idle timeout for proxy connections - Pass insecure flag through run_http_server
- Rename proxy to upstream_proxy - Rename insecure to upstream_insecure
- Handle CONNECT requests separately - Keep original absolute URIs - Fix URI handling for non-absolute URIs - Clean up imports
- Add hyper-http-proxy dependency - Replace custom proxy implementation with ProxyConnector - Simplify request handling using dedicated proxy toolkit - Clean up imports and unused code
- Add proxy configuration to HTTPS server - Pass proxy settings to both HTTP and HTTPS servers - Fix main function to handle proxy configuration correctly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new forwarder abstraction for handling HTTP requests in the proxy server and removes sensitive files.
Changes:
Security:
This change will make it easier to add different forwarding strategies in the future, such as proxy support, load balancing, or custom request handling, while maintaining proper security practices.