Fix tests error log by enabling LogPlugin only once

benches/idle.rs

@@ -1,13 +1,13 @@
 use divan::Bencher;
-use valence::prelude::*;
+use valence::{prelude::*, testing};
 
 /// Benches the performance of a single server tick while nothing much is
 /// happening.
 #[divan::bench]
 pub(crate) fn idle_update(bencher: Bencher) {
     let mut app = App::new();
 
-    app.add_plugins(DefaultPlugins);
+    testing::add_plugins(&mut app);
     app.add_systems(Startup, setup);
 
     // Run startup schedule.

benches/many_players.rs

@@ -8,11 +8,10 @@ use valence::keepalive::KeepaliveSettings;
 use valence::layer::chunk::UnloadedChunk;
 use valence::layer::LayerBundle;
 use valence::math::DVec3;
-use valence::network::NetworkPlugin;
 use valence::protocol::packets::play::{FullC2s, HandSwingC2s};
 use valence::registry::{BiomeRegistry, DimensionTypeRegistry};
-use valence::testing::create_mock_client;
-use valence::{ident, ChunkPos, DefaultPlugins, Hand, Server, ServerSettings};
+use valence::testing::{self, create_mock_client};
+use valence::{ident, ChunkPos, Hand, Server, ServerSettings};
 use valence_server::CompressionThreshold;
 
 #[divan::bench]
@@ -37,8 +36,7 @@ fn run_many_players(bencher: Bencher, client_count: usize, view_dist: u8, world_
         period: Duration::MAX,
     });
 
-    app.add_plugins(DefaultPlugins.build().disable::<NetworkPlugin>());
-
+    testing::add_plugins(&mut app);
     app.update(); // Initialize plugins.
 
     let mut layer = LayerBundle::new(

src/testing.rs

@@ -1,10 +1,11 @@
 use std::collections::VecDeque;
 use std::net::{IpAddr, Ipv4Addr};
-use std::sync::{Arc, Mutex};
+use std::sync::{Arc, Mutex, Once};
 use std::time::{Duration, Instant};
 
 use bevy_app::prelude::*;
 use bevy_ecs::prelude::*;
+use bevy_log::LogPlugin;
 use bytes::{Buf, BufMut, BytesMut};
 use uuid::Uuid;
 use valence_ident::ident;
@@ -18,6 +19,34 @@ use valence_server::protocol::{Decode, Encode, Packet, PacketDecoder, PacketEnco
 use valence_server::{ChunkLayer, EntityLayer, Server, ServerSettings};
 
 use crate::DefaultPlugins;
+
+/// Add plugins to `app` with [`NetworkPlugin`] disabled.
+///
+/// Also, for tests usually run in the same context, the
+/// logger and the subscriber in [`LogPlugin`] should only
+/// be initialized once. So only the first test executing
+/// this will have [`LogPlugin`] enabled. Other tests will
+/// have [`LogPlugin`] disabled.
+pub fn add_plugins(app: &mut App) {
+    static ONCE: Once = Once::new();
+    let mut is_first = false;
+
+    ONCE.call_once(|| {
+        is_first = true;
+    });
+
+    let plugins = if is_first {
+        DefaultPlugins.build().disable::<NetworkPlugin>()
+    } else {
+        DefaultPlugins
+            .build()
+            .disable::<NetworkPlugin>()
+            .disable::<LogPlugin>()
+    };
+
+    app.add_plugins(plugins);
+}
+
 pub struct ScenarioSingleClient {
     /// The new bevy application.
     pub app: App,
@@ -43,9 +72,9 @@ impl ScenarioSingleClient {
         .insert_resource(ServerSettings {
             compression_threshold: Default::default(),
             ..Default::default()
-        })
-        .add_plugins(DefaultPlugins.build().disable::<NetworkPlugin>());
+        });
 
+        add_plugins(&mut app);
         app.update(); // Initialize plugins.
 
         let chunk_layer = ChunkLayer::new(

src/tests/example.rs

@@ -12,15 +12,14 @@ use crate::entity::Position;
 use crate::inventory::{Inventory, InventoryKind, OpenInventory};
 use crate::math::DVec3;
 use crate::protocol::packets::play::{InventoryS2c, OpenScreenS2c, PositionAndOnGroundC2s};
-use crate::testing::ScenarioSingleClient;
-use crate::{DefaultPlugins, Server};
+use crate::testing::{self, ScenarioSingleClient};
+use crate::Server;
 
 /// The server's tick should increment every update.
 #[test]
 fn example_test_server_tick_increment() {
     let mut app = App::new();
-
-    app.add_plugins(DefaultPlugins);
+    testing::add_plugins(&mut app);
 
     let tick = app.world_mut().resource::<Server>().current_tick();