Skip to content

Sample Helm chart - #63

Open
jseiser wants to merge 1 commit into
valeriansaliou:masterfrom
jseiser:HELM_CHART
Open

Sample Helm chart#63
jseiser wants to merge 1 commit into
valeriansaliou:masterfrom
jseiser:HELM_CHART

Conversation

@jseiser

@jseiser jseiser commented Oct 28, 2020

Copy link
Copy Markdown

I wouldn't merge this, but if you wanted to create a helm chart repo, and use something like github pages to publish it, its a working chart that I am using myself.

@bduron

bduron commented Apr 9, 2021

Copy link
Copy Markdown

Hey @jseiser thank you for this clean Helm chart!

I deployed my Vigil release using it, but somehow the vigil pod keeps restarting like every ~30 minutes.
And it doesn't increase the pod restarts count which always displays 0.
(The service looks stable though)

Would you have any idea why it behaves this way? Thank you!

@gbonnefille

Copy link
Copy Markdown

This is really useful. Please, merge it or create a dedicated project for it (with link from vigil project)

metadata:
{{- with .Values.podAnnotations }}
annotations:
checksum/config: {{ include (print $.Template.BasePath "/secrets.yaml") . | sha256sum }}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's no secrets.yaml therefore no reason to restart the Pod if this file updates

- name: vigil
configMap:
name: {{ include "vigil.fullname" . }}
defaultMode: 0777

@dminca dminca Aug 24, 2021

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the app doesn't need to write anything there, it's just pointing to the configuration file therefore this mode is redundant in this case

{{- if semverCompare ">=1.14-0" .Capabilities.KubeVersion.GitVersion -}}
apiVersion: networking.k8s.io/v1beta1
{{- else -}}
apiVersion: extensions/v1beta1

@dminca dminca Aug 24, 2021

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will not be compatible with Kubernetes v1.19+ which uses

apiVersion: networking.k8s.io/v1

https://kubernetes.io/docs/concepts/services-networking/ingress/

logo_url = "{{ .Values.vigil.logo_url }}"
website_url = "{{ .Values.vigil.website_url }}"
support_url = "{{ .Values.vigil.support_url }}"
custom_html = "{{ .Values.vigil.customer_html }}"

@dminca dminca Aug 24, 2021

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably default these to the sample config.cfg that we have in this repo so that at least the app boots properly & healthiness/readiness probes pass. Default only if not overridden.

At least the user will be able to port-forward to the service and see if the status page is working & how it looks initially (as a demo).

dminca added a commit to dminca/vigil that referenced this pull request Sep 17, 2021
it's enough to get you started, just install it and do a port-forward to
:8080 and you'll have a demo status page at your disposal

Resolves: valeriansaliou#63
Related:
Signed-off-by: Daniel-Andrei Minca <mandrei17@gmail.com>
@devopsmariocom

Copy link
Copy Markdown

Is there any plan for official HELM chart?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants