Skip to content

Conversation

@WikiRik
Copy link
Member

@WikiRik WikiRik commented Nov 9, 2025

Updates the rollup version we use and introduces a separate build step in the CI so we test on the files that will also be published to npm. This also allows us to more easily update eslint in a future PR. It's a feat because there might be (very) minor changes to the build itself.

This incorporates part of the changes of #2401

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)
  • References provided in PR (where applicable)

@codecov
Copy link

codecov bot commented Nov 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (f2b5c17) to head (a661988).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #2629   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          114       114           
  Lines         2566      2566           
  Branches       651       651           
=========================================
  Hits          2566      2566           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@WikiRik WikiRik requested review from profnandaa and rubiin November 9, 2025 10:40
@WikiRik WikiRik marked this pull request as ready for review November 9, 2025 10:53
rubiin
rubiin previously approved these changes Nov 9, 2025
@WikiRik
Copy link
Member Author

WikiRik commented Nov 9, 2025

Because I want to validate that the regression of #2630 does not happen here, I will put this in draft

@WikiRik WikiRik marked this pull request as draft November 9, 2025 21:29
@WikiRik
Copy link
Member Author

WikiRik commented Nov 10, 2025

I specified the target for compilation in a661988 (#2629) and manually validated that it does not introduce the same regression as #2630

@WikiRik WikiRik marked this pull request as ready for review November 10, 2025 22:01
@WikiRik WikiRik requested a review from rubiin November 10, 2025 22:01
Copy link
Member

@rubiin rubiin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM then

@WikiRik
Copy link
Member Author

WikiRik commented Nov 21, 2025

@profnandaa if possible I want to include this in the next release as well, together with #2633

Copy link
Member

@tux-tn tux-tn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work on refreshing the old dependencies and tooling. It's really great to see progress in this area! Even though I haven’t contributed in the last few years, I’d be more than happy to help out where I can. I had tried to work on something back in #1869, but life happened and I never managed to finish it.

I also have a few suggestions and topics I’d like to raise. Do you think I should open a dedicated discussion issue for tooling, or is there already an ongoing conversation somewhere that I could join?

Regarding this PR specifically:

  • Import attributes and in particular with { type: "json" } , aren’t supported in Node.js versions < 20.10.0. Since the Babel transpilation hook was removed from the build:browser command, this may break support for older Node.js versions.

  • Node.js 24 is now the current LTS, so we probably want to add it to the CI test matrix.

Happy to discuss further and help where needed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants