Set client lib-name to GlideSpringDataValkey - #87
Conversation
Signed-off-by: Alex Le <alex.le@improving.com>
Signed-off-by: Alex Le <alex.le@improving.com>
| configBuilder.subscriptionConfiguration(subConfigBuilder.build()); | ||
|
|
||
| // Set library name for server-side client identification | ||
| configBuilder.libName("GlideSpringDataValkey"); |
There was a problem hiding this comment.
Makes sense to me that Spring Data Valkey would override the underlying Java driver (i.e. GlideJava to GlideSpringDataValkey). The Jedis compat layer does something similar. Although would like @jamesx-improving to confirm this is correct.
There was a problem hiding this comment.
It's definitely arguable to say the least. I would push back on the Jedis comp layer case if I had the chance, as it introduced a precedent that a wrapper using glide underneath could claim its own lib-name, opening the door for future outer wrapper to change their lib-name as well, which would be an endless situation.
Of course I don't have the final say here, and I'm open to counterarguments.
There was a problem hiding this comment.
After reviewing existing lib names, I think setting lib name for Spring Data Valkey makes sense. Users can still set client name (which we don't set), and we maintain observability into which specific client/library is being used for devops.
3 participants
Overivew
This PR set the reported
lib-nameto GlideSpringDataValkey.Two small sanity tests were added.
Related Issues
#81