Skip to content

Use subpath in websocket URL #471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ravjotbrar merged 3 commits into from
Aug 13, 2026
Merged

Use subpath in websocket URL #471

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f6b9859
Extract websocket host logic into getWebsocketHost function
tkesgar Aug 12, 2026
4b08ff3
Rename function getWebsocketHost to getWebsocketURL
tkesgar Aug 12, 2026
553b13b
Update apps/frontend/src/state/epics/wsEpics.ts
tkesgar Aug 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions apps/frontend/src/state/epics/wsEpics.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,14 +26,19 @@

let socket$: WebSocketSubject<PayloadAction> | null = null

const isElectron = window.location.protocol === "file:"
const isHttps = window.location.protocol === "https:"
const getWebsocketURL = () => {
const isElectron = window.location.protocol === "file:"
if (isElectron) {
return "ws://localhost:8080"
}

return (window.location.origin + window.location.pathname)
.replace(/^http/, 'ws')

Check failure on line 36 in apps/frontend/src/state/epics/wsEpics.ts

View workflow job for this annotation

GitHub Actions / lint 

Strings must use doublequote
}
Comment thread
tkesgar marked this conversation as resolved.

const url =
import.meta.env.VITE_VALKEY_ADMIN_WS_URL ||
(isElectron
? "ws://localhost:8080"
: `${isHttps ? "wss" : "ws"}://${window.location.host}`)
getWebsocketURL()

const connect = (store: Store) =>
action$.pipe(
Expand Down
Loading