Pass metrics uri to backend - #81
Merged
Merged
Conversation
Signed-off-by: Argus Li <contactme@chunkeili.com>
Signed-off-by: Argus Li <contactme@chunkeili.com>
| const metricsServerURIs: Map<string, string> = new Map() | ||
|
|
||
| process.on("message", (message) => { | ||
| if (message && message.type === "metrics-started") { |
Collaborator
There was a problem hiding this comment.
can message be null | undefined actually?
Contributor
Author
There was a problem hiding this comment.
It can be undefined but not null.
Collaborator
There was a problem hiding this comment.
you can then write
if (message?.type === "metrics-started")
Signed-off-by: Argus Li <contactme@chunkeili.com>
ravjotbrar
reviewed
Nov 21, 2025
| metricsProcess.on('message', (message) => { | ||
| if (message && message.type === 'metrics-started') { | ||
| console.log(`Metrics server for ${serverConnectionId} started successfully on host: ${message.payload.metricsHost} port ${message.payload.metricsPort}`); | ||
| serverProcess.send?.({ |
Collaborator
There was a problem hiding this comment.
Should this be process.post?
Contributor
Author
There was a problem hiding this comment.
It's confusing as there's both electron and node.js option. In this case, it's send as this is a node.js child process. https://nodejs.org/dist/latest-v16.x/docs/api/child_process.html#subprocesssendmessage-sendhandle-options-callback
Signed-off-by: Argus Li <contactme@chunkeili.com>
arseny-kostenko
approved these changes
Nov 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a Metrics instance is created, we now pass the metrics server uri to the server app, where it is stored in a map of valkeyServerInstanceID to its respective metrics server URI.
On metrics instance close, we delete the metrics URI from the server.