Added filters to rebuild only the changed images #59
+16
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hanxi Zhang <[email protected]>
Signed-off-by: Hanxi Zhang <[email protected]>
Nikhil-Manglore
approved these changes
Oct 8, 2025
Signed-off-by: Hanxi Zhang <[email protected]>
Signed-off-by: Hanxi Zhang <[email protected]>
Signed-off-by: Hanxi Zhang <[email protected]>
hanxizh9910
force-pushed
the
optimize-rebuild-ci
branch
from
f484e61 to
0486e06
Compare
Signed-off-by: Hanxi Zhang <[email protected]>
Signed-off-by: Hanxi Zhang <[email protected]>
…ker files Signed-off-by: Hanxi Zhang <[email protected]>
Signed-off-by: Hanxi Zhang <[email protected]>
Signed-off-by: Hanxi Zhang <[email protected]>
Signed-off-by: Hanxi Zhang <[email protected]>
Signed-off-by: Hanxi Zhang <[email protected]>
Signed-off-by: Hanxi Zhang <[email protected]>
… mainline Signed-off-by: Hanxi Zhang <[email protected]>
…n when make a PR or push to mainline Signed-off-by: Hanxi Zhang <[email protected]>
…o job to run for push to mainline Signed-off-by: Hanxi Zhang <[email protected]>
Signed-off-by: Hanxi Zhang <[email protected]>
|
Hi @sarthakaggarwal97, here are the screenshots showing how I tested the changes. I’ve also linked the PR from my personal fork. Expected BehaviorThe expected behavior is as follows: when pushing to the mainline branch, only the version whose Dockerfile has been modified should be built. If no Dockerfile is changed, no image should be built. For pushes to other branches or for pull requests, all jobs should run. Only modified 8.1 dockerfile: hanxizh9910#20PR:
Push to mainline:
Modified both 8.1 and 9.0:hanxizh9910#21PR:
Push to mainline:
Modified the ci.yml(not a dockerfile):hanxizh9910#22PR:
Push to mainline:
|
Signed-off-by: Sarthak Aggarwal <[email protected]>
sarthakaggarwal97
approved these changes
Oct 9, 2025
There was a problem hiding this comment.
LGTM! Thanks @hanxizh9910 for taking this up and testing it. @roshkhatri and @Nikhil-Manglore please take a look. It'll be good to have this for 9.0 GA.
|
@roshkhatri I will merge this EOD :D |
|
Yeah it looks good to me |
roshkhatri
approved these changes
Oct 13, 2025
| echo "strategy=$(jq -c . <<<"$strategy")" >> "$GITHUB_OUTPUT" | ||
| jq . <<<"$strategy" # debugging aid to visually inspect the generated matrix | ||
There was a problem hiding this comment.
Why are we removing this line?
Signed-off-by: Roshan Khatri <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When releasing new changes, all Docker images are rebuilt even when only one version changes. This wastes significant time and resources.
Solution
This PR adds change detection to the CI workflow and detect which version folder changed.
Testing
Verified the optimization works for: