-
Notifications
You must be signed in to change notification settings - Fork 11
Fix CI workflow to handle missing Docker Hub secrets #62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hanxizh9910
wants to merge
32
commits into
valkey-io:mainline
Choose a base branch
from
hanxizh9910:issue-23-clean
base: mainline
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
8f6c0b8
Modified ci.yml to run without fail when there is no secrets
hanxizh9910 e7e44dc
Removed some space and fixed some comments
hanxizh9910 f282639
Used more descriptive names for the job and id
hanxizh9910 491dcb5
Added back the name for update docker description job
hanxizh9910 768d652
Test: expect all the versions pusing to dockerhub when merge to mainline
hanxizh9910 f475c50
Added filters to rebuild only the changed images
hanxizh9910 cdc2222
Removed a comment
hanxizh9910 2d13cd4
Removed a duplicated comment
hanxizh9910 a4e87b2
Added back original debugging aid
hanxizh9910 30cd931
Test: check if the modified images will be built
hanxizh9910 0fadad5
Check if both images will be built
hanxizh9910 959dd5c
Test: multiple files change and workflow will detect the modified doc…
hanxizh9910 c315973
revert the dummy changes
hanxizh9910 fe5a71b
Added a comment to check
hanxizh9910 c238710
modified readme
hanxizh9910 4973bc4
Avoid rebuilding the images if it is pushing to mainline
hanxizh9910 f2af212
revmoed a dummy change
hanxizh9910 b972e7d
Test: dockerfile change, expect only the 8.1 jobs to run when push to…
hanxizh9910 c205325
Test: multiple dockerfile changes, expect both 8.1 and 9.0 jobs to ru…
hanxizh9910 587bc0a
Test: Dummy change to ci.yml, expect all the jobs to run for PR and n…
hanxizh9910 8f9f9e3
Test: Expect all versions to push to dockerhub when merge to mainline
hanxizh9910 1762743
Test: reverted changes to both images, expect them to push to dockerhub
hanxizh9910 f6124d5
Removed an error due to merge conflict issue before
hanxizh9910 5a0518f
Test: has secrets, expect all versions to be pushed when merging to m…
hanxizh9910 00827de
Test again, try to push the images when merge to the mainline
hanxizh9910 cf67691
Last test, removed secrets, and expect nothing to be pushed but not f…
hanxizh9910 47d3007
Fix: fix the error when multiple changed files were flattened to one …
hanxizh9910 f6923d0
Test: check if there is no dockerfile modified, expect: all the test …
hanxizh9910 8a6469d
Test: has secrets, expect all tests to run for PR and push to mainlin
hanxizh9910 a3a0930
Clean the dummy tests
hanxizh9910 7741b57
Removed the dummy change of README.md
hanxizh9910 5447c73
Removed dummy change of README
hanxizh9910 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.