Failure Detector Expansion 3/5: Attach gtest console output to unit-test failures

[BChan-0]

Stacked on #79 (1/5) and #82 (2/5). Those two commits are this branch's base, so the file list and diff include them. It's best to review and merge in numerical order; the diff size will lower as they merge (I think)

This PR builds on 2/5, which adds the shared run-log download this reuses. The producer side is valkey PR 4292.

Issue

gtest-parallel's JSON dump records a per-test verdict and timings, nothing else. When the extraction action cannot find the test's own log file it falls back to a bare gtest FAIL, so the issue names the test that failed and says nothing about why: no assertion, no file and line, no expected and actual values.

PR Summary

A unit-test failure whose artifact entry holds only a verdict has its gtest block. read back from the job log. Blocks are delimited by gtest-parallel's own progress lines and anchored on the closing returned with exit code line rather than the next test's header, so a block stays intact when tests run in parallel and their output interleaves.

Output is attributed to the most recently opened block, not to every open one, which would copy one test's assertion into another's issue. A test that failed and then passed on a retry contributes nothing: gtest-parallel reruns failures, and a zero-code close discards whatever the earlier attempt recorded.

Enrichment applies only to the bare-verdict fallback. When the action did find the test's own log it already carries the full assertion, and the run log interleaves every worker's output, so overwriting it would trade a complete diagnostic for the two progress lines around it.

The run's log zip is downloaded at most once and shared with timeout recovery.

Testing

Added:

• tests/test_testfailuredetector_gtest_log_parser.py: TestParseGtestFailuresFromLog
• tests/test_testfailuredetector_timeout_parser.py: TestSharedRunLogsAcrossConsumers, plus coverage that an extracted log is not replaced and a bare verdict is filled in

1529 total tests passed.

[coderabbitai]

Warning

Review limit reached

@BChan-0, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 59 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: fce77296-94c9-4829-8725-6aa7cd82cc55

📥 Commits

Reviewing files that changed from the base of the PR and between cab64ac and dd6bfdb.

📒 Files selected for processing (18)

• scripts/common/issue_dedup.py
• scripts/common/workflow_artifacts.py
• scripts/test_failure_detector/download.py
• scripts/test_failure_detector/gtest_log_parser.py
• scripts/test_failure_detector/issue_renderer.py
• scripts/test_failure_detector/main.py
• scripts/test_failure_detector/manage_issues.py
• scripts/test_failure_detector/parse_failures.py
• scripts/test_failure_detector/timeout_parser.py
• scripts/test_failure_detector/timeout_recovery.py
• tests/test_issue_dedup.py
• tests/test_testfailuredetector_download.py
• tests/test_testfailuredetector_failure_parser.py
• tests/test_testfailuredetector_gtest_log_parser.py
• tests/test_testfailuredetector_issue_manager.py
• tests/test_testfailuredetector_main.py
• tests/test_testfailuredetector_timeout_parser.py
• tests/test_workflow_artifacts.py

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}