Failure Detector Expansion 5/5: Separate server startup failures by cause

[BChan-0]

Stacked on #79 (1/5). This branch contains 1/5's commit as its base, so the file list and diff include it. It's best to review and merge in numerical order, but this PR should be ok to merge after 1/5 and doesnt need to wait on 3/5; the diff size will lower as they merge

The producer side is valkey PR 4292.

Issue

A startup failure arrives as Can't start <exe> followed by the whole config file under CONFIGURATION: and then the reason under ERROR:. The config dump is dozens of lines identical across causes, so it filled the identity's
significant-line window before the reason was reached: every startup failure reduced to the same identity regardless of why the server refused to start.

Across the 34 Daily artifacts checked, 46 startup entries carry two genuinely distinct causes ("Bad directive or wrong number of arguments" and "Configuration issue prevented Valkey startup") that collapsed into one issue, so one of the two was never reported. The title was affected the same way: it read Can't start valkey-server for every cause, and on the valgrind jobs the config dump's own LEAK SUMMARY: line could win the title outright.

The executable path had the same problem in the other direction. It is the runner's workspace layout, not anything about the bug — /home/runner/... on Linux, /Users/runner/... on macOS, /__w/... in a container — so one startup bug split into an issue per platform. All three shapes appear in the real artifacts.

PR Summary

The config dump is collapsed before normalization and the executable path is reduced to its basename, so the identity keys on the fatal reason and one startup bug is one issue across platforms.

Finding that reason means skipping what sits in front of it: the harness's ### Starting server marker, the *** FATAL CONFIG FILE ERROR banner that is identical for every config error, the position line that moves whenever the config
file changes, and the >>> echo of the offending directive. What is left is the reason itself. When the server never came up at all the runner hands over the whole log instead of a fatal-error blob, and there is no reason to parse; the failure is still named rather than falling through to a title built from the log's first line.

The title carries the reason for the same reason the identity does, so two causes are tellable apart in an issue list and one issue is not retitled as the config dump's contents shift.

Testing

Added:

• tests/test_testfailuredetector_failure_parser.py: TestStartupFailureIdentity, plus test_startup_reason_line_distinguishes_failures
• tests/test_testfailuredetector_issue_manager.py: TestStartupFailureTitle, TestExceptionTitle

1472 total tests passed.

[coderabbitai]

Warning

Review limit reached

@BChan-0, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 59 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 614aef8b-4240-462c-ade8-840fcc9f0358

📥 Commits

Reviewing files that changed from the base of the PR and between cab64ac and 80e436a.

📒 Files selected for processing (9)

• scripts/common/issue_dedup.py
• scripts/common/workflow_artifacts.py
• scripts/test_failure_detector/issue_renderer.py
• scripts/test_failure_detector/manage_issues.py
• scripts/test_failure_detector/parse_failures.py
• tests/test_issue_dedup.py
• tests/test_testfailuredetector_failure_parser.py
• tests/test_testfailuredetector_issue_manager.py
• tests/test_workflow_artifacts.py

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}