valkey-search: Add more configurations #335
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arad Zilberstein <[email protected]>
Signed-off-by: Arad Zilberstein <[email protected]>
madolson
reviewed
Aug 5, 2025
| 4. `search.query-string-terms-count`: Controls the maximum number of terms (nodes in the predicate tree) allowed in a | ||
| query string for FT.SEARCH commands. (Default: 16, Min: 1, Max: 32) | ||
|
|
||
| 5. `search.max-indexes`: Controls the maximum number of search indexes that can be created. |
There was a problem hiding this comment.
Are all of these breaking changes? All of these seem like limits that didn't exist before. Are we releasing these with Valkey 9.0?
madolson
reviewed
Aug 20, 2025
| - `search_ingest_field_tag`: Count of tag fields processed during ingestion | ||
| - `search_ingest_last_batch_size`: Size of the most recent ingestion batch processed | ||
| - `search_ingest_total_batches`: Count of total ingestion batches processed | ||
| - `search_ingest_total_failures`: Count of ingestion failures across all operations |
| 17. `--max-vector-ef-runtime`: (Optional) Controls the maximum EF_RUNTIME parameter for HNSW algorithm. (Default: 4096) | ||
| 18. `--max-vector-knn`: (Optional) Controls the maximum K value for K-nearest neighbor searches. (Default: 128) | ||
| 19. `--max-search-result-record-size`: (Optional) Controls the maximum size in bytes for search result records. (Default: 5242880) | ||
| 20. `--max-search-result-fields-count`: (Optional) Controls the maximum number of fields in search result records. (Default: 500) |
There was a problem hiding this comment.
These are also all following the wrong format. They should be using the search.max-search-result-fields-count, the same as the dynamic configs. All the duplicated ones need to be listed twice.
zuiderkwast
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added additional configurations to the valkey search module.
valkey-io/valkey-search#239
valkey-io/valkey-search#231
valkey-io/valkey-search#229
valkey-io/valkey-search#214