Fix set_then_get Lua function signatures - #309
Open
lntutor wants to merge 2 commits into
Open
Conversation
Author
|
Current head 2981661 is mergeable, the DCO check is green on this head, and I do not see any unresolved review threads or contributor-side follow-up remaining. This looks ready for maintainer review when convenient. |
Aryex
added
bug
Aryex
approved these changes
Aug 6, 2026
Aryex
left a comment
Aryex
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for fixing this. lgtm.
jeremyprime
reviewed
Aug 7, 2026
Signed-off-by: Loi Nguyen <vanloi999@gmail.com>
Signed-off-by: Loi Nguyen <vanloi999@gmail.com>
lntutor
force-pushed
the
docs/301-fix-lua-function-signature
branch
from
August 8, 2026 09:00
2981661 to
0906b16
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates every
set_then_getexample to accept Valkey Functions’(keys, args)arrays and index the first key and argument before callingSETandGET.Validation
pnpm run format:check:mdxpnpm buildgit diff --checkChecklist
mainFixes #301