Backport #192: Valkey::Future placeholders for pipelined/multi to release-1.0 - #205
Merged
Merged
Conversation
Aryex
marked this pull request as ready for review
July 30, 2026 00:47
…ed`/`multi` (#192) * Nested array args fix Signed-off-by: Sasidharan Gopal <sasidharan.gopal94@gmail.com> * Adress review comments: simplify comments, move doc to method, rename flattened var Signed-off-by: Sasidharan Gopal <sasidharan.gopal94@gmail.com> * Initial commit for future object support Signed-off-by: Sasidharan Gopal <sasidharan.gopal94@gmail.com> * Reject unsupported command argument types (nil, Array, Hash, etc.) in build_command_args instead of silently coercing via to_s, matching redis-rb/redis-client's behavior (fixes #191) Signed-off-by: Sasidharan Gopal <sasidharan.gopal94@gmail.com> * Fixing CI tests Signed-off-by: Sasidharan Gopal <sasidharan.gopal94@gmail.com> * Fixing real use-after-free-bug in scripting commands flow Signed-off-by: Sasidharan Gopal <sasidharan.gopal94@gmail.com> * Wrap ttl/offset/increment args in Integer() in setex/set/getex/setrange/incrby/decrby. Matches redis-rb's own handling of these same arguments - without it, any object that isn't a literal Integer but is numeric-convertible now raises under build_command_args' stricter argument-type check instead of being silently coerced. Signed-off-by: Sasidharan Gopal <sasidharan.gopal94@gmail.com> --------- Signed-off-by: Sasidharan Gopal <sasidharan.gopal94@gmail.com> (cherry picked from commit f1199ae) Signed-off-by: Alex Le <alex.le@improving.com>
Aryex
force-pushed
the
backport/release-1.0/future-object-support
branch
from
July 30, 2026 00:47
adc4c43 to
a438ea5
Compare
This was referenced Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Valkey::Futureplaceholders for commands queued insidepipelined/multi#192 (f1199aef) torelease-1.0.Valkey::Futureplaceholders returned by commands queued insidepipelined/multi, so callers can reference each queued reply after the batch resolves.build_command_argsargument-type checks,Integer()coercion forsetex/set/getex/setrange/incrby/decrbynumeric args, and the scripting use-after-free fix.Cherry-picked cleanly with
git cherry-pick -x— no conflicts.