fix: short-circuit scan/scan_each to empty in cluster mode - #252
Merged
Conversation
Aryex
force-pushed
the
alexl/scan-cluster-empty-guard
branch
from
August 7, 2026 21:44
afa567e to
07454c1
Compare
Aryex
force-pushed
the
alexl/scan-cluster-empty-guard
branch
from
August 7, 2026 21:48
07454c1 to
5833ba7
Compare
Signed-off-by: Alex Le <alex.le@improving.com>
Aryex
force-pushed
the
alexl/scan-cluster-empty-guard
branch
from
August 7, 2026 21:53
5833ba7 to
9831339
Compare
Aryex
marked this pull request as ready for review
August 7, 2026 21:58
yipin-chen
approved these changes
Aug 7, 2026
yipin-chen
left a comment
yipin-chen
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. nit: Should we remove TODO in the comment and just keep issue links?
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scanandscan_eachare standalone mode only. This PR adds additional comments clarifications. It also return empty results if scan is used oncluster_mode.Cluster support to be added in #133
Test plan
bundle exec rubocop lib/valkey/commands/generic_commands.rb test/lint/generic_commands.rb— cleanruby -con both files — syntax OKbundle exec rake test:standalone— deferred (no local standalone server up at the time of push); please verify in CIbundle exec rake test:cluster— deferred (no local cluster up at the time of push); the newcluster_mode?branches intest_scan/test_scan_eachare what exercises the guard, so CI is the load-bearing check here