WIP adding macos shared object - #27
Closed
alireza-nobakht wants to merge 1 commit into
Closed
Conversation
Signed-off-by: Alireza Nobakht <nobakht.job@gmail.com>
alireza-nobakht
force-pushed
the
feature-macos-shared-object
branch
from
July 15, 2025 13:52
d56fd42 to
be8e862
Compare
mohsen-alizadeh
self-requested a review
July 16, 2025 20:44
mohsen-alizadeh
marked this pull request as draft
July 17, 2025 13:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automate Rust FFI Build & Improve Cross-Platform Support
Summary
This PR adds a new script
build_ffi.shto automate:valkey-glide.soon Linux,.dylibon macOS) viacargo build --releaselib/valkeyfolderWhy?
The Rust shared library must be rebuilt and copied manually before, which is error-prone and tedious. This script simplifies and automates that, keeping the library up-to-date locally.
Prerequisites
Rust toolchain (includes
cargo)Install via official Rust installer:
Protocol Buffers compiler (protoc)
Required by the Rust build process. On macOS, install with:
How to run
From your valkey-glide-ruby gem root, run:
Important: Cargo.toml change needed
To support building a dynamic shared library for Ruby FFI, the Rust crate’s Cargo.toml (in ffi/) must include:
Currently it only builds static libs (staticlib, rlib), which are incompatible with Ruby FFI.
I’m happy to prepare a PR for this change in the Rust repo if the maintainers agree.