Implement connection refresh on circular moved (#5893) - #6023
Merged
Conversation
* Implement connection refresh on circular moved Signed-off-by: Alex Rehnby-Martin <alex.rehnby-martin@improving.com> * fix: format redirect_node.map() call on single line Signed-off-by: Alex Rehnby-Martin <alex.rehnby-martin@improving.com> * fix(redis-rs): handle circular MOVED redirect in pipeline path Extract shared is_circular_moved_redirect() function to detect when a MOVED redirect points to the same address (circular redirect). Apply this detection to both single command and pipeline paths. For pipelines, circular MOVED errors now route through the reconnect logic instead of the normal redirect logic, matching the behavior of single commands. Added test to verify pipeline commands recover from circular MOVED + disconnect scenarios. Signed-off-by: Alex Rehnby-Martin <alex.rehnby-martin@improving.com> * chore(deps-dev): bump maturin from 1.13.1 to 1.13.3 in /python in the patch-updates group across 1 directory (#5910) chore(deps-dev): bump maturin Bumps the patch-updates group with 1 update in the /python directory: [maturin](https://github.com/pyo3/maturin). Updates `maturin` from 1.13.1 to 1.13.3 - [Release notes](https://github.com/pyo3/maturin/releases) - [Changelog](https://github.com/PyO3/maturin/blob/main/Changelog.md) - [Commits](PyO3/maturin@v1.13.1...v1.13.3) --- updated-dependencies: - dependency-name: maturin dependency-version: 1.13.3 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: patch-updates ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Alex Rehnby-Martin <alex.rehnby-martin@improving.com> * fix(redis-rs): improve circular MOVED detection with hostname/IP resolution - Add resolve_address parameter to is_circular_moved_redirect to handle cases where MOVED returns an IP but client connected via hostname - Fix resolve_address to preserve original port when resolving IP to hostname (the MOVED response port is authoritative) - Extend circular MOVED detection to pipeline path via handle_redirect_logic - Add unit tests for hostname vs IP detection scenarios - Add integration test for pipeline circular MOVED handling Signed-off-by: Alex Rehnby-Martin <alex.rehnby-martin@improving.com> * style: fix cargo fmt formatting Signed-off-by: Alex Rehnby-Martin <alex.rehnby-martin@improving.com> --------- Signed-off-by: Alex Rehnby-Martin <alex.rehnby-martin@improving.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> (cherry picked from commit 87c9991) Signed-off-by: James Xin <james.xin@improving.com>
xShinnRyuu
approved these changes
May 26, 2026
Aryex
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Back-porting PR #5893 to
release-2.4