Core: Allow creation of RESP3 connections. #669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barshaul
reviewed
Dec 11, 2023
barshaul
approved these changes
Dec 11, 2023
shachlanAmazon
force-pushed
the
enable-resp3
branch
3 times, most recently
from
3d4d093 to
8e98ea1
Compare
|
@barshaul I added another commit, with test fixes that were required by the changes to redis-rs. |
shachlanAmazon
force-pushed
the
enable-resp3
branch
2 times, most recently
from
12e182d to
98c6a59
Compare
barshaul
reviewed
Dec 13, 2023
python/python/pybushka/constants.py
Outdated
| @@ -9,7 +9,7 @@ | |||
| # Typing | |||
| T = TypeVar("T") | |||
| TOK = Literal["OK"] | |||
| TResult = Union[TOK, str, List[str], List[List[str]], int, None] | |||
| TResult = Union[TOK, str, List[str], List[List[str]], int, None, dict[str, str]] | |||
There was a problem hiding this comment.
Change dict to Dict (import from Typing)
There was a problem hiding this comment.
It should be Dict[str, T], as we can get different response types
shachlanAmazon
force-pushed
the
enable-resp3
branch
from
98c6a59 to
6728482
Compare
barshaul
approved these changes
Dec 13, 2023
These tests were broken by clusters returning maps instead of arrays.
shachlanAmazon
force-pushed
the
enable-resp3
branch
from
6728482 to
fc74f22
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on amazon-contributing/redis-rs#74.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.