Skip to content

Allow luajit to coexist with built-in lua - #5

Merged
secwall merged 1 commit into
masterfrom
coexistence
Mar 25, 2026
Merged

Allow luajit to coexist with built-in lua#5
secwall merged 1 commit into
masterfrom
coexistence

Conversation

@secwall

@secwall secwall commented Mar 25, 2026

Copy link
Copy Markdown
Collaborator

Adds a module config "engine-name"

dvkashapov
dvkashapov previously approved these changes Mar 25, 2026

@dvkashapov dvkashapov left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really clever, overall LGTM! Just some minor comments.
I was having an idea about handling shebang also in SCRIPT LOAD but that would require changes in core and parsing code itself in core. We also need to update README to mention that it is required now to load LuaJIT first if it is expected to use both default and LuaJIT

Comment thread tests/coexistence/function-coexistence.tcl Outdated
Comment thread src/engine_luajit.c
Comment thread tests/coexistence/run-coexistence-tests.sh
Signed-off-by: secwall <secwall@yandex-team.ru>
@secwall
secwall merged commit 7581a88 into master Mar 25, 2026
5 checks passed
@secwall
secwall deleted the coexistence branch March 25, 2026 16:31
@dvkashapov dvkashapov linked an issue Mar 25, 2026 that may be closed by this pull request
@zuiderkwast

zuiderkwast commented Mar 25, 2026

Copy link
Copy Markdown

I was having an idea about handling shebang also in SCRIPT LOAD but that would require changes in core and parsing code itself in core.

Oh, so using a shebang doesn't work with EVAL and SCRIPT LOAD? I wasn't aware of that!

I think we should fix it in the core. Ricardo would know. He knows everything about scripting engines. :D

We also need to update README to mention that it is required now to load LuaJIT first if it is expected to use both default and LuaJIT

Yeah, I think the only reason to use both at the same time is to do testing and benchmarking, such as comparing them to each other.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[NEW] Support valkey-luajit and default module coexistence

3 participants