-
Notifications
You must be signed in to change notification settings - Fork 934
Roll backward downgrade compatibility from Redis 7.0/7.2 and Valkey 7.2/8.0 to Redis 6.0 #2549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 6.0
Are you sure you want to change the base?
Conversation
…key 7.2/8.0 Signed-off-by: Satheesha Chattenahalli Hanume Gowda <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for submitting the change along with #2550 #2551.
Just a high level comment:
Could we make these change as individual commits to be able to stack on top of each other. Will be easier for us to create for 8.1/9.0 in the future.
OR
Individual commits based on the feature support like listpack to ziplist, hostname support, etc. This would enable folks to easily pick it for their needs and support older version if required in their case.
|
|
||
| /* Node coordinates */ | ||
| ci = sdscatprintf(sdsempty(),"%.40s %s:%d@%d ", | ||
| ci = sdscatprintf(sdsempty(),"%.40s %s:%d@%d", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if we need to add hostname support, we would need to bring in extensions mechanism to older version as well.
| node->ip, | ||
| node->port, | ||
| node->cport); | ||
| if (node->hostname && sdslen(node->hostname) > 0) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be good to add a nodes.conf file with hostname in it and verify it gets loaded fine.
|
See comment #2551 (comment) |
|
Continuing the conversation here as it's the largest of all changes. @zuiderkwast IIUC the intention here is not to merge into different branch of this project (already signalled by @satheeshaGowda by "NOT TO BE MERGED"). Rather with this PR we are able to visaulize the diff and provide feedback. We could maintain these patches independently under the Valkey organisation in a separate repo and folks can use it for their usecases where they might need to rollback after usage of new features in the latest version. |
===========NOT TO BE MERGED======
This patch extends Redis 6.0 to support roll forward upgrade and roll backward downgrade compatibility with
Listpack to Ziplist Conversion Process