Valkey release 9.0.0-rc2

.github/ISSUE_TEMPLATE/bug_report.md

@@ -2,7 +2,7 @@
 name: Bug report
 about: Help us improve by reporting a bug
 title: '[BUG]'
-labels: ''
+labels: ['bug']
 assignees: ''
 
 ---

.github/ISSUE_TEMPLATE/crash_report.yml

@@ -1,6 +1,7 @@
 name: Crash report
 description: Submit a crash report
 title: '[CRASH] <short description>'
+labels: ['bug']
 body:
   - type: markdown
     attributes:

.github/ISSUE_TEMPLATE/feature_request.md

@@ -2,7 +2,7 @@
 name: Feature request
 about: Suggest a feature
 title: '[NEW]'
-labels: ''
+labels: ['enhancement']
 assignees: ''
 
 ---

.github/ISSUE_TEMPLATE/test-failure.md

@@ -0,0 +1,24 @@
+---
+name: Test failure
+about: Report a failing or a flaky test
+title: '[TEST-FAILURE] <short description>'
+labels: ['test-failure']
+assignees: ''
+---
+
+<!--Before submitting a test failure report, please check open issues to ensure this failure has not already been reported. -->
+
+**Summary**
+
+A short description of the failure.
+
+**Failing test(s)**
+
+- Test name:
+- CI link(s):
+
+**Error stack trace**
+
+A relevant stack trace for the test failure.
+
+> **Tip:** Copy and paste the full stack trace from the CI output into your issue, as CI links may expire over time.

.github/benchmark_configs/pr_benchmark.json

@@ -0,0 +1,53 @@
+[
+  {
+    "requests": [100000000],
+    "keyspacelen": [10000000],
+    "data_sizes": [16],
+    "pipelines": [10],
+    "clients": [50],
+    "commands": [
+      "SET",
+      "GET",
+      "MSET",
+      "MGET"
+    ],
+    "cluster_mode": false,
+    "tls_mode": false,
+    "warmup": 120,
+    "server_cpu_range": "0",
+    "client_cpu_range": "55,95"
+  },
+  {
+    "requests": [100000000],
+    "keyspacelen": [10000000],
+    "data_sizes": [16],
+    "pipelines": [10],
+    "clients": [50],
+    "commands": [
+      "SET",
+      "GET"
+    ],
+    "cluster_mode": true,
+    "tls_mode": false,
+    "warmup": 120,
+    "server_cpu_range": "0",
+    "client_cpu_range": "55,95"
+  },
+  {
+    "requests": [100000000],
+    "keyspacelen": [3000000],
+    "data_sizes": [512],
+    "pipelines": [10],
+    "clients": [650],
+    "commands": [
+      "SET",
+      "GET"
+    ],
+    "cluster_mode": false,
+    "tls_mode": false,
+    "warmup": 180,
+    "io-threads": 8,
+    "server_cpu_range": "0-7",
+    "client_cpu_range": "55,95"
+  }
+]

.github/workflows/auto-author-assign.yml

@@ -0,0 +1,14 @@
+name: Auto Author Assign
+
+on:
+  pull_request_target:
+    types: [opened, reopened]
+
+permissions:
+  pull-requests: write
+
+jobs:
+  assign-author:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: toshimaru/auto-author-assign@16f0022cf3d7970c106d8d1105f75a1165edb516 # v2.1.1

.github/workflows/benchmark-on-label.yml

@@ -0,0 +1,139 @@
+name: On-demand Benchmark
+
+on:
+  pull_request_target:
+    types: [labeled]
+
+concurrency:
+  group: valkey-benchmark
+  cancel-in-progress: false
+
+defaults:
+  run:
+    shell: "bash -Eeuo pipefail -x {0}"
+
+permissions:
+  contents: read
+  pull-requests: write
+  issues: write
+
+jobs:
+  benchmark:
+    runs-on: ${{ github.repository == 'valkey-io/valkey' && fromJSON('["self-hosted","ec2-ubuntu-24.04-benchmarking"]') || 'ubuntu-latest' }}
+    if: |
+      github.event.action == 'labeled' && github.event.label.name == 'run-benchmark'
+    steps:
+      - name: Checkout valkey
+        uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
+        with:
+          path: valkey
+          fetch-depth: 0
+          ref: ${{ github.event.pull_request.merge_commit_sha }}
+          persist-credentials: false
+
+      - name: Checkout valkey-perf-benchmark
+        uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
+        with:
+          repository: ${{ github.repository_owner }}/valkey-perf-benchmark
+          path: valkey-perf-benchmark
+          fetch-depth: 1
+          persist-credentials: false
+
+      - name: Set up Python
+        uses: actions/setup-python@a26af69be951a213d495a4c3e4e4022e16d87065 # v5
+        with:
+          python-version: "3.10"
+          cache: "pip"
+
+      - name: Install dependencies
+        working-directory: valkey-perf-benchmark
+        run: |
+          sudo apt-get update
+          sudo apt-get install -y build-essential
+          pip install -r requirements.txt
+
+      - name: Run benchmarks
+        working-directory: valkey-perf-benchmark
+        run: |
+          CONFIG_FILE="../valkey/.github/benchmark_configs/pr_benchmark.json"
+
+          # Removes server/client CPU range args if running in private repo
+          if [[ "${{ github.repository }}" != "valkey-io/valkey" ]]; then
+            jq 'map(del(.server_cpu_range, .client_cpu_range))' "$CONFIG_FILE" > tmp.json && mv tmp.json "$CONFIG_FILE"
+          fi
+
+          # Base benchmark arguments
+          BENCHMARK_ARGS=(
+            --commits "${{ github.event.pull_request.merge_commit_sha }}"
+            --baseline "${{ github.event.pull_request.base.ref }}"
+            --results-dir "results"
+            --valkey-path "../valkey"
+            --config "$CONFIG_FILE"
+          )
+
+          # Run benchmark
+          python ./benchmark.py "${BENCHMARK_ARGS[@]}"
+
+      - name: Compare results
+        working-directory: valkey-perf-benchmark
+        run: |
+          python ./utils/compare_benchmark_results.py \
+            ./results/${{ github.event.pull_request.base.ref }}/metrics.json \
+            ./results/${{ github.event.pull_request.merge_commit_sha }}/metrics.json \
+            ../comparison.md
+
+      - name: Upload artifacts
+        if: always()
+        continue-on-error: true
+        uses: actions/upload-artifact@6f51ac03b9356f520e9adb1b1b7802705f340c2b # v4.5.0
+        with:
+          name: benchmark-results
+          path: |
+            ./valkey-perf-benchmark/results/${{ github.event.pull_request.merge_commit_sha }}/metrics.json
+            ./valkey-perf-benchmark/results/${{ github.event.pull_request.base.ref }}/metrics.json
+            comparison.md
+
+      - name: Comment PR with results
+        uses: actions/github-script@5c56fde4671bc2d3592fb0f2c5b5bab9ddae03b1 # v7
+        with:
+          github-token: ${{ secrets.GITHUB_TOKEN }}
+          script: |
+            const fs = require('fs');
+            const body = fs.readFileSync('comparison.md', 'utf8');
+            const {owner, repo} = context.repo;
+            const sha = '${{ github.event.pull_request.head.sha }}';
+            const short = sha.slice(0,7);
+            const link = `[\`${short}\`](https://github.com/${owner}/${repo}/commit/${sha})`
+            await github.rest.issues.createComment({
+              issue_number: context.issue.number,
+              owner,
+              repo,
+              body: `**Benchmark ran on this commit:** ${link}\n\n${body}`
+            });
+
+      - name: Cleanup any running valkey processes
+        if: always()
+        continue-on-error: true
+        run: |
+          pkill -f valkey
+          exit_code=$?
+          if [ $exit_code -eq 0 ]; then
+            echo "✓ Killed running valkey processes"
+          elif [ $exit_code -eq 1 ]; then
+            echo "No valkey processes found to kill"
+          else
+            echo "Warning: pkill failed with exit code $exit_code"
+          fi
+
+      - name: Remove ${{ github.event.label.name }} label
+        if: always() && github.event.label.name == 'run-benchmark'
+        uses: actions/github-script@5c56fde4671bc2d3592fb0f2c5b5bab9ddae03b1 # v7
+        with:
+          github-token: ${{ secrets.GITHUB_TOKEN }}
+          script: |
+            await github.rest.issues.removeLabel({
+              issue_number: context.issue.number,
+              owner: context.repo.owner,
+              repo: context.repo.repo,
+              name: '${{ github.event.label.name }}'
+            }).catch(err => console.log('label not present', err.message));