-
Notifications
You must be signed in to change notification settings - Fork 992
Adding unit tests for sha256 #2632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## unstable #2632 +/- ##
============================================
+ Coverage 72.22% 72.23% +0.01%
============================================
Files 127 127
Lines 70936 70936
============================================
+ Hits 51232 51244 +12
+ Misses 19704 19692 -12 🚀 New features to boost your workflow:
|
Signed-off-by: korjeek <[email protected]>
Signed-off-by: korjeek <[email protected]>
Signed-off-by: korjeek <[email protected]>
f37a5d0
to
de17b15
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine. I am not against adding these tests (maybe they can help in a future need to change the sha256 implementation...) biut can you please through some words on the top comment to explain what you are adding and why?
Signed-off-by: korjeek <[email protected]>
Thank you @korjeek I meant the top comment :) , but adding these comments in the test file also works. |
@korjeek can you PTAL at the test failures and fix? |
Signed-off-by: korjeek <[email protected]>
seems like I fixed it |
Adding comprehensive unit tests for SHA-256 implementation.
These tests verify:
The tests ensure compatibility with standard SHA-256 implementations and will help detect regressions during future code changes.