Skip to content

Conversation

zhijun42
Copy link
Contributor

@zhijun42 zhijun42 commented Sep 20, 2025

A super tiny change to optimize the function sentinelAskPrimaryStateToOtherSentinels to early return when the sentinel does not observe the primary as subjectively down.

I ran ./runtest-sentinel locally and saw no breaking change.

Signed-off-by: Zhijun <[email protected]>
Copy link

codecov bot commented Sep 20, 2025

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.20%. Comparing base (8d562d2) to head (7f25d71).

Files with missing lines Patch % Lines
src/sentinel.c 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           unstable    #2633      +/-   ##
============================================
- Coverage     72.22%   72.20%   -0.02%     
============================================
  Files           127      127              
  Lines         70936    70934       -2     
============================================
- Hits          51232    51219      -13     
- Misses        19704    19715      +11     
Files with missing lines Coverage Δ
src/sentinel.c 0.00% <0.00%> (ø)

... and 13 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zhijun42 zhijun42 changed the title sentinel: skip IS-PRIMARY-DOWN-BY-ADDR requests when primary not SDOWN Sentinel: Skip IS-PRIMARY-DOWN-BY-ADDR requests when primary not SDOWN Sep 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant