Skip to content

Conversation

@enjoy-binbin
Copy link
Member

These fields under INFO STATS should need to be reset:

  • acl_access_denied_auth
  • acl_access_denied_cmd
  • acl_access_denied_key
  • acl_access_denied_channel
  • acl_access_denied_tls_cert

These fields under INFO STATS should need to be reset:
- acl_access_denied_auth
- acl_access_denied_cmd
- acl_access_denied_key
- acl_access_denied_channel
- acl_access_denied_tls_cert

Signed-off-by: Binbin <[email protected]>
@enjoy-binbin enjoy-binbin added the major-decision-pending Major decision pending by TSC team label Dec 2, 2025
@dvkashapov
Copy link
Contributor

Is it a good idea to reset security-adjacent stats in general case? What use-case do you have in mind?

@codecov
Copy link

codecov bot commented Dec 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.42%. Comparing base (4a0e20b) to head (e91f909).

Additional details and impacted files
@@             Coverage Diff              @@
##           unstable    #2891      +/-   ##
============================================
- Coverage     72.44%   72.42%   -0.02%     
============================================
  Files           128      128              
  Lines         70487    70487              
============================================
- Hits          51066    51052      -14     
- Misses        19421    19435      +14     
Files with missing lines Coverage Δ
src/server.c 88.43% <100.00%> (ø)

... and 11 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@enjoy-binbin
Copy link
Member Author

Is it a good idea to reset security-adjacent stats in general case? What use-case do you have in mind?

I think it is ok? If the admin call the config resetstat, he know what he was doing. I don't have the use case, just playing with it and find it.

@hwware
Copy link
Contributor

hwware commented Dec 2, 2025

Could you pls introduce more detail cases?

@enjoy-binbin
Copy link
Member Author

Could you pls introduce more detail cases?

@hwware what do you mean? I mentioned this in my previous comments, i don't have the usercase right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

major-decision-pending Major decision pending by TSC team

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

3 participants