Add server side TLS certificate expiry tracking and INFO telemetry #2913
+180
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YiwenZhang12
changed the title
YiwenZhang12
changed the title
Signed-off-by: Yiwen Zhang <[email protected]>
YiwenZhang12
force-pushed
the
feature/server_cert
branch
from
5e796c7 to
5534e39
Compare
Author
|
Hi @zuiderkwast , since we discussed this in the issue, I wanted to share the PR here. This PR is still missing tests, before I add them, I wanted to check whether the overall approach looks correct to you. No rush at all, and happy to iterate based on your feedback. Thank you! |
Signed-off-by: Yiwen Zhang <[email protected]>
YiwenZhang12
force-pushed
the
feature/server_cert
branch
from
371e49d to
1ce7c35
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
regarding issue: #2784
Adding TLS certificate expiration parsing on the OpenSSL side and refresh the cached expiry at startup, CONFIG TLS changes, and hourly.
Emit a NOTICE when the server cert is expiring (with days remaining) and a WARNING once it expires.
Expose a new # TLS section in INFO with tls_enabled and tls_server_cert_expires_in_seconds so monitoring can alert on impending expiry.
Log:
INFO: