Repository navigation
Let native titlebar dragging handle double-click maximize - #91
Merged
Merged
Conversation
The titlebar drag area already declares Tauri's native drag region. Calling startDragging on mouse down from that same region races the double-click maximize path on Windows, causing the window to restore immediately after maximizing. Constraint: Preserve the existing custom titlebar and window controls. Rejected: Add debounce logic around double-click maximize | Removing the duplicate drag path is smaller and avoids timing-dependent behavior. Confidence: high Scope-risk: narrow Directive: Keep manual startDragging off elements marked data-tauri-drag-region unless native dragging is intentionally removed. Tested: bun run biome check --write . Tested: bun run tsc -b Tested: cargo check Not-tested: Manual Windows double-click titlebar check on this upstream PR branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
startDragging()call from the titlebar drag region.data-tauri-drag-regionand leave double-click totoggleMaximize().Why
On Windows, the native drag region and manual
startDragging()can fight the double-click maximize path: the window maximizes and then immediately restores back to windowed mode.Verification
bun run biome check --write .bun run tsc -bcargo checkNotes
This keeps the existing custom titlebar and window controls unchanged.