Fix iso_name + don't destroy iso when using iso_name#195
Draft
AtaxyaNetwork wants to merge 1 commit intovatesfr:mainfrom
Draft
Fix iso_name + don't destroy iso when using iso_name#195AtaxyaNetwork wants to merge 1 commit intovatesfr:mainfrom
AtaxyaNetwork wants to merge 1 commit intovatesfr:mainfrom
Conversation
Collaborator
|
Ho nice ! |
Collaborator
Author
Member
|
Oh nice! This could save a few minutes for each run, I like this. I am wondering what would happen if there are two or more iso with the same name in same or different SR? Should we also use |
Collaborator
Author
|
If several ISO has the same name, packer throw an error: iso_uuid is a good idea, but since everything in this provider is using names, using uuid here would be weird. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Now we can use packer like this, instead of using
iso_urlandiso_checksumAlso, when using
iso_name, packer is now NOT deleting the iso we gave. Usually the goal when using iso_name is to not re-upload the iso 397826231 times, so not deleting it is better :DCurrently working, but still need some tests, so i'm marking it as WiP.