Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python kernel (without sos-python) does not work #328

Closed
BoPeng opened this issue Sep 18, 2021 · 10 comments
Closed

Python kernel (without sos-python) does not work #328

BoPeng opened this issue Sep 18, 2021 · 10 comments

Comments

@BoPeng
Copy link
Contributor

BoPeng commented Sep 18, 2021

image

@zoq
Copy link

zoq commented Sep 20, 2021

I can see the same issue using - https://mybinder.org/v2/gh/mlpack/examples/HEAD

/srv/conda/envs/notebook/lib/python3.7/site-packages/sos_notebook/kernel.py:1320: RuntimeWarning: coroutine 'ZMQSocketChannel.msg_ready' was never awaited
  while self.KC.shell_channel.msg_ready():
RuntimeWarning: Enable tracemalloc to get the object allocation traceback
/srv/conda/envs/notebook/lib/python3.7/site-packages/sos_notebook/kernel.py:1321: RuntimeWarning: coroutine 'ZMQSocketChannel.get_msg' was never awaited
  self.KC.shell_channel.get_msg()
RuntimeWarning: Enable tracemalloc to get the object allocation traceback

not only with the python kernel but with any other kernel I tested as well.

@BoPeng
Copy link
Contributor Author

BoPeng commented Sep 20, 2021

This may be due to an upgrade of some jupyter packages. I will have to identify which one is the culprit.

@bioworkflows
Copy link

The binder image has

jovyan@jupyter-mlpack-2dexamples-2dy4qd1grt:~$ jupyter --version
jupyter core     : 4.7.1
jupyter-notebook : 6.3.0
qtconsole        : not installed
ipython          : 7.27.0
ipykernel        : 5.1.4
jupyter client   : 7.0.2
jupyter lab      : 3.1.11
nbconvert        : 6.0.7
ipywidgets       : 7.6.3
nbformat         : 5.1.3
traitlets        : 5.1.0

According to this post, downgrading jupyter-client to 6.1.12 should work.

@bioworkflows
Copy link

jupyter/jupyter_client#623 is the PR that adds async to get_message

@BoPeng BoPeng transferred this issue from vatlab/jupyterlab-sos Sep 21, 2021
BoPeng added a commit that referenced this issue Sep 21, 2021
BoPeng added a commit that referenced this issue Sep 21, 2021
@BoPeng
Copy link
Contributor Author

BoPeng commented Sep 21, 2021

This is getting complicated because jupyter notebook itself does not work well with the new version of jupyter_client by default.

see jupyter/notebook#6164

@zoq
Copy link

zoq commented Sep 21, 2021

Looks like a workaround is to downgrade Pyzmq and jupyter_client. Looks like you are doing some work in the async branch, happy to test it out as well.

@BoPeng
Copy link
Contributor Author

BoPeng commented Sep 23, 2021

@zoq I think I have fixed sos-notebook and jupyterlab-sos, could you please test them?

@BoPeng
Copy link
Contributor Author

BoPeng commented Sep 23, 2021

It is the async branch.

@zoq
Copy link

zoq commented Sep 23, 2021

@BoPeng Awesome works great, tested with the C++, JavaScript and Python3 kernel.

@BoPeng
Copy link
Contributor Author

BoPeng commented Sep 23, 2021

Thanks. I have released sos-notebook 0.22.7, and will release a conda-forge version soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants