Skip to content

Conversation

@Laserlicht
Copy link
Collaborator

No description provided.

@Laserlicht Laserlicht merged commit 5632efb into vcmi-1.7 Oct 3, 2025
1 check passed
@Laserlicht Laserlicht deleted the vert_new_button branch October 3, 2025 18:33
@GeorgeK1ng
Copy link
Contributor

I have also prepared similar config for normal 900+. But I think there should be more configurable dynamic way. Currently it looks like every one town / hero place require standalone buttons and frames config.. Not very comfort to prepare..

@Laserlicht
Copy link
Collaborator Author

Laserlicht commented Oct 3, 2025

I have also prepared similar config for normal 900+. But I think there should be more configurable dynamic way. Currently it looks like every one town / hero place require standalone buttons and frames config.. Not very comfort to prepare..

Yes. But making it dynamic isn't that easy too.

Lists are relatively easy. Just let them calculate itself if not defined:
int itemsCount = input["itemsCount"].Integer();
to
int itemsCount = input["itemsCount"].isNull() ? (area.h / 32) - 1 : input["itemsCount"].Integer();
But not perfect if it window height does not fit in 32 px raster.
And change area with enough space (e.g. using bottom instead of height).

Buttons are much harder. But not because the code. More because of logic. When use big, when small buttons? Prefer more buttons over fewer big buttons? What about combined layouts (OH3 layout)?

@GeorgeK1ng
Copy link
Contributor

I will try to prepare some kind of usable logic. Have some ideas, lets see if Its then doable for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants