chore(core): Upgrade Vector to Rust 1.68 (clippy fixes only) #16745

fuchsnj · 2023-03-09T18:26:31Z

…6580) Reverts: #15869 This reverts commit f90ca9e.

* fix(pulsar sink): Rename batch size option To be consistent with other sink batch options. Signed-off-by: Jesse Szwedko <[email protected]> * Update src/sinks/pulsar.rs Co-authored-by: Spencer Gilbert <[email protected]> --------- Signed-off-by: Jesse Szwedko <[email protected]> Co-authored-by: Spencer Gilbert <[email protected]>

Signed-off-by: Jesse Szwedko <[email protected]>

…oads pages (#16441) * attempt to add header * Remove from header, add to footer and release pages Signed-off-by: Jesse Szwedko <[email protected]> * Remove extra whitespace Signed-off-by: Jesse Szwedko <[email protected]> --------- Signed-off-by: Jesse Szwedko <[email protected]> Co-authored-by: Jesse Szwedko <[email protected]>

* Revert "chore(deps): upgrade AWS crates to v0.54.1 (#16443)" This reverts commit 0d084c2. * Revert "chore(deps): Update aws-sdks to 0.23 and aws supporting crates to 0.53 (#16365)" This reverts commit f4e90e1. Signed-off-by: Jesse Szwedko <[email protected]>

* Remove default_max_length default Signed-off-by: Stephen Wakely <[email protected]> * Remove default_max_length default from unix Signed-off-by: Stephen Wakely <[email protected]> * Update configurable docs Signed-off-by: Stephen Wakely <[email protected]> --------- Signed-off-by: Stephen Wakely <[email protected]>

Co-authored-by: neuronull <[email protected]> Signed-off-by: Jesse Szwedko <[email protected]>

netlify · 2023-03-09T18:26:39Z

✅ Deploy Preview for vector-project canceled.

Name	Link
🔨 Latest commit	`30d2417`
🔍 Latest deploy log	https://app.netlify.com/sites/vector-project/deploys/640b5c2a190e810008c5ba07

netlify · 2023-03-09T18:26:39Z

✅ Deploy Preview for vrl-playground ready!

Name	Link
🔨 Latest commit	`30d2417`
🔍 Latest deploy log	https://app.netlify.com/sites/vrl-playground/deploys/640b5c2aab1c6300087f93e2
😎 Deploy Preview	https://deploy-preview-16745--vrl-playground.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

fuchsnj · 2023-03-09T18:49:16Z

Docker images for Rust 1.68 don't exist yet, so integration tests will fail until those are uploaded

bruceg · 2023-03-09T18:55:36Z

src/sources/socket/mod.rs

@@ -835,7 +835,7 @@ mod test {
            .unwrap();

        // Spawn the source task and wait until we're sure it's listening:
-        let _ = tokio::spawn(source_task);
+        std::mem::drop(tokio::spawn(source_task));


These could be just drop, as it is part of the standard prelude.

lib/vrl/compiler/src/lib.rs

src/api/schema/sort.rs

Cargo.toml

fuchsnj · 2023-03-10T16:36:17Z

We are still running into the ICE we saw in 1.67 here. It appears that this does work with 1.69 (beta), so the plan is to keep the clippy changes, and revert this back to 1.66.1 until 1.69 hits stable.

github-actions · 2023-03-10T17:20:49Z

Regression Detector Results

Run ID: 4f6da76b-0f2e-40aa-8f89-a30b176667ac
Baseline: 2d476ea
Comparison: 30d2417
Total vector CPUs: 7

Explanation

A regression test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine quickly if vector performance is changed and to what degree by a pull request.

The table below, if present, lists those experiments that have experienced a statistically significant change in mean optimization goal performance between baseline and comparison SHAs with 90.00% confidence OR have been detected as newly erratic. Negative values mean that baseline is faster, positive comparison. Results that do not exhibit more than a ±5.00% change in their mean optimization goal are discarded. An experiment is erratic if its coefficient of variation is greater than 0.1. The abbreviated table will be omitted if no interesting change is observed.

No interesting changes in experiment optimization goals with confidence ≥ 90.00% and |Δ mean %| ≥ 5.00%.

Fine details of change detection per experiment.

experiment	goal	Δ mean	Δ mean %	confidence	baseline mean	baseline stdev	baseline stderr	baseline outlier %	baseline CoV	comparison mean	comparison stdev	comparison stderr	comparison CoV	erratic	declared erratic
file_to_blackhole	egress throughput	450.01KiB/CPU-s	6.71	99.03%	6.54MiB/CPU-s	4.14MiB/CPU-s	123.56KiB/CPU-s	10.423729	0.63305	6.98MiB/CPU-s	3.79MiB/CPU-s	122.43KiB/CPU-s	0.54241	True	True
syslog_regex_logs2metric_ddmetrics	ingress throughput	99.43KiB/CPU-s	2.75	100.00%	3.53MiB/CPU-s	352.91KiB/CPU-s	4.34KiB/CPU-s	0.0	0.097544	3.63MiB/CPU-s	392.61KiB/CPU-s	4.83KiB/CPU-s	0.105612	True	True
otlp_http_to_blackhole	ingress throughput	39.22KiB/CPU-s	2.54	100.00%	1.51MiB/CPU-s	125.81KiB/CPU-s	1.55KiB/CPU-s	0.0	0.081621	1.54MiB/CPU-s	113.52KiB/CPU-s	1.4KiB/CPU-s	0.071819	False	False
http_text_to_http_json	ingress throughput	420.18KiB/CPU-s	1.70	100.00%	24.1MiB/CPU-s	684.62KiB/CPU-s	8.42KiB/CPU-s	0.0	0.027734	24.51MiB/CPU-s	660.96KiB/CPU-s	8.13KiB/CPU-s	0.026328	False	False
datadog_agent_remap_datadog_logs	ingress throughput	445.13KiB/CPU-s	1.33	100.00%	32.67MiB/CPU-s	1.38MiB/CPU-s	17.32KiB/CPU-s	0.0	0.042084	33.11MiB/CPU-s	903.61KiB/CPU-s	11.12KiB/CPU-s	0.026652	False	False
http_to_http_acks	ingress throughput	62.48KiB/CPU-s	1.16	79.62%	5.24MiB/CPU-s	2.78MiB/CPU-s	35.03KiB/CPU-s	0.0	0.530046	5.3MiB/CPU-s	2.74MiB/CPU-s	34.5KiB/CPU-s	0.515966	True	False
datadog_agent_remap_blackhole_acks	ingress throughput	334.8KiB/CPU-s	1.06	100.00%	30.91MiB/CPU-s	1.41MiB/CPU-s	17.82KiB/CPU-s	0.0	0.045753	31.24MiB/CPU-s	1.23MiB/CPU-s	15.48KiB/CPU-s	0.039316	False	False
syslog_loki	ingress throughput	65.24KiB/CPU-s	0.74	100.00%	8.56MiB/CPU-s	218.04KiB/CPU-s	2.68KiB/CPU-s	0.0	0.024876	8.62MiB/CPU-s	172.69KiB/CPU-s	2.12KiB/CPU-s	0.019557	False	False
http_to_http_json	ingress throughput	49.17KiB/CPU-s	0.35	100.00%	13.57MiB/CPU-s	303.75KiB/CPU-s	3.74KiB/CPU-s	0.0	0.021854	13.62MiB/CPU-s	220.03KiB/CPU-s	2.71KiB/CPU-s	0.015775	False	False
otlp_grpc_to_blackhole	ingress throughput	1.86KiB/CPU-s	0.18	97.35%	1.03MiB/CPU-s	48.32KiB/CPU-s	608.87B/CPU-s	0.0	0.046031	1.03MiB/CPU-s	47.81KiB/CPU-s	602.45B/CPU-s	0.045469	False	False
datadog_agent_remap_datadog_logs_acks	ingress throughput	18.94KiB/CPU-s	0.06	74.31%	33.42MiB/CPU-s	1.04MiB/CPU-s	13.12KiB/CPU-s	0.0	0.03116	33.44MiB/CPU-s	840.4KiB/CPU-s	10.34KiB/CPU-s	0.024542	False	False
enterprise_http_to_http	ingress throughput	4.1KiB/CPU-s	0.03	71.42%	13.62MiB/CPU-s	247.55KiB/CPU-s	3.05KiB/CPU-s	0.0	0.01775	13.62MiB/CPU-s	190.18KiB/CPU-s	2.34KiB/CPU-s	0.013633	False	False
syslog_humio_logs	ingress throughput	1.31KiB/CPU-s	0.01	28.17%	8.86MiB/CPU-s	200.91KiB/CPU-s	2.47KiB/CPU-s	0.0	0.022154	8.86MiB/CPU-s	216.17KiB/CPU-s	2.66KiB/CPU-s	0.023833	False	False
fluent_elasticsearch	ingress throughput	632.38B/CPU-s	0.00	76.14%	45.41MiB/CPU-s	30.45KiB/CPU-s	379.7B/CPU-s	0.0	0.000655	45.41MiB/CPU-s	30.41KiB/CPU-s	379.12B/CPU-s	0.000654	False	False
splunk_hec_to_splunk_hec_logs_acks	ingress throughput	309.43B/CPU-s	0.00	3.62%	13.61MiB/CPU-s	397.64KiB/CPU-s	4.89KiB/CPU-s	0.0	0.02852	13.61MiB/CPU-s	366.84KiB/CPU-s	4.51KiB/CPU-s	0.02631	False	False
http_to_http_noack	ingress throughput	6.74B/CPU-s	0.00	0.09%	13.61MiB/CPU-s	340.8KiB/CPU-s	4.19KiB/CPU-s	0.0	0.024449	13.61MiB/CPU-s	339.86KiB/CPU-s	4.18KiB/CPU-s	0.024382	False	False
splunk_hec_indexer_ack_blackhole	ingress throughput	-82.73B/CPU-s	-0.00	1.38%	13.61MiB/CPU-s	267.05KiB/CPU-s	3.28KiB/CPU-s	0.0	0.019155	13.61MiB/CPU-s	268.74KiB/CPU-s	3.31KiB/CPU-s	0.019276	False	False
splunk_hec_to_splunk_hec_logs_noack	ingress throughput	-1.05KiB/CPU-s	-0.01	17.98%	13.62MiB/CPU-s	262.42KiB/CPU-s	3.23KiB/CPU-s	0.0	0.01882	13.61MiB/CPU-s	269.3KiB/CPU-s	3.31KiB/CPU-s	0.019315	False	False
splunk_hec_route_s3	ingress throughput	-32.25KiB/CPU-s	-0.27	99.67%	11.49MiB/CPU-s	556.06KiB/CPU-s	6.84KiB/CPU-s	0.0	0.047255	11.46MiB/CPU-s	698.18KiB/CPU-s	8.59KiB/CPU-s	0.059495	False	False
socket_to_socket_blackhole	ingress throughput	-67.9KiB/CPU-s	-0.51	100.00%	13.06MiB/CPU-s	312.77KiB/CPU-s	3.85KiB/CPU-s	0.0	0.023391	12.99MiB/CPU-s	476.38KiB/CPU-s	5.86KiB/CPU-s	0.035808	False	False
syslog_splunk_hec_logs	ingress throughput	-49.42KiB/CPU-s	-0.56	100.00%	8.67MiB/CPU-s	309.25KiB/CPU-s	3.8KiB/CPU-s	0.0	0.03483	8.62MiB/CPU-s	267.05KiB/CPU-s	3.29KiB/CPU-s	0.030245	False	False
datadog_agent_remap_blackhole	ingress throughput	-437.69KiB/CPU-s	-1.35	100.00%	31.64MiB/CPU-s	970.01KiB/CPU-s	11.94KiB/CPU-s	0.0	0.029932	31.22MiB/CPU-s	1.17MiB/CPU-s	14.79KiB/CPU-s	0.037601	False	False
syslog_log2metric_splunk_hec_metrics	ingress throughput	-155.5KiB/CPU-s	-1.66	100.00%	9.14MiB/CPU-s	352.13KiB/CPU-s	4.33KiB/CPU-s	0.0	0.037618	8.99MiB/CPU-s	317.09KiB/CPU-s	3.9KiB/CPU-s	0.034447	False	False
syslog_log2metric_humio_metrics	ingress throughput	-133.34KiB/CPU-s	-2.07	100.00%	6.3MiB/CPU-s	139.98KiB/CPU-s	1.72KiB/CPU-s	0.0	0.021681	6.17MiB/CPU-s	271.24KiB/CPU-s	3.34KiB/CPU-s	0.042897	False	False

bruceg

Nice cleanups.

jszwedko and others added 15 commits February 24, 2023 15:34

chore(kafka): revert make consumer group instance id configurable (#1…

9ab2701

…6580) Reverts: #15869 This reverts commit f90ca9e.

chore(releasing): Prepare v0.28.0 release

e562c98

Signed-off-by: Jesse Szwedko <[email protected]>

chore(releasing): Fix tag detection

971c594

Signed-off-by: Jesse Szwedko <[email protected]>

chore(releasing): Add known issues for 0.28.0. (#16649)

764c542

Signed-off-by: Jesse Szwedko <[email protected]>

chore(releasing): Prepare v0.28.1 release

ff15924

Co-authored-by: neuronull <[email protected]> Signed-off-by: Jesse Szwedko <[email protected]>

save

20914e4

save

cc4f3ed

save

e0d7770

save

9de1b16

Merge branch 'master' into fuchsnj/rust_1.68

c24543a

save

1fc2fc5

github-actions bot added domain: core Anything related to core crates i.e. vector-core, core-common, etc domain: sinks Anything related to the Vector's sinks domain: sources Anything related to the Vector's sources domain: vrl Anything related to the Vector Remap Language labels Mar 9, 2023

fuchsnj added 2 commits March 9, 2023 13:27

update more versions

128b3f2

save

f00e47f

fuchsnj added the ci-condition: integration tests enable Run integration tests on this PR label Mar 9, 2023

fuchsnj marked this pull request as ready for review March 9, 2023 18:44

fuchsnj requested a review from a team March 9, 2023 18:44

fuchsnj requested a review from neuronull as a code owner March 9, 2023 18:44

fuchsnj requested a review from a team March 9, 2023 18:44

fuchsnj requested review from davidhuie-dd and spencergilbert as code owners March 9, 2023 18:44

fuchsnj requested a review from StephenWakely as a code owner March 9, 2023 18:44

fuchsnj requested a review from a team March 9, 2023 18:44

bruceg approved these changes Mar 9, 2023

View reviewed changes

spencergilbert approved these changes Mar 9, 2023

View reviewed changes

lib/vrl/compiler/src/lib.rs Outdated Show resolved Hide resolved

src/api/schema/sort.rs Outdated Show resolved Hide resolved

cleanup

0108a0f

jszwedko reviewed Mar 10, 2023

View reviewed changes

Cargo.toml Outdated Show resolved Hide resolved

fuchsnj added 3 commits March 10, 2023 08:56

revert MSRV

95837c3

fix formatting

0ac98e6

revert version back to 1.66.1

30d2417

fuchsnj changed the title ~~chore(core): Upgrade Vector to Rust 1.68~~ chore(core): Upgrade Vector to Rust ~1.68~ (clippy fixes only) Mar 10, 2023

fuchsnj changed the title ~~chore(core): Upgrade Vector to Rust ~1.68~ (clippy fixes only)~~ chore(core): Upgrade Vector to Rust 1.68 (clippy fixes only) Mar 10, 2023

bruceg approved these changes Mar 10, 2023

View reviewed changes

fuchsnj merged commit 23770c8 into master Mar 10, 2023

fuchsnj deleted the fuchsnj/rust_1.68 branch March 10, 2023 21:42

fuchsnj mentioned this pull request Mar 13, 2023

Upgrade to rust 1.69 #16744

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore(core): Upgrade Vector to Rust 1.68 (clippy fixes only) #16745

chore(core): Upgrade Vector to Rust 1.68 (clippy fixes only) #16745

Uh oh!

fuchsnj commented Mar 9, 2023 •

edited

Loading

Uh oh!

netlify bot commented Mar 9, 2023 •

edited

Loading

Uh oh!

netlify bot commented Mar 9, 2023 •

edited

Loading

Uh oh!

fuchsnj commented Mar 9, 2023

Uh oh!

bruceg Mar 9, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fuchsnj commented Mar 10, 2023

Uh oh!

github-actions bot commented Mar 10, 2023

Uh oh!

bruceg left a comment

Uh oh!

Uh oh!

chore(core): Upgrade Vector to Rust 1.68 (clippy fixes only) #16745

chore(core): Upgrade Vector to Rust 1.68 (clippy fixes only) #16745

Uh oh!

Conversation

fuchsnj commented Mar 9, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

netlify bot commented Mar 9, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for vector-project canceled.

Uh oh!

netlify bot commented Mar 9, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for vrl-playground ready!

Uh oh!

fuchsnj commented Mar 9, 2023

Uh oh!

bruceg Mar 9, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fuchsnj commented Mar 10, 2023

Uh oh!

github-actions bot commented Mar 10, 2023

Regression Detector Results

Uh oh!

bruceg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

fuchsnj commented Mar 9, 2023 •

edited

Loading

netlify bot commented Mar 9, 2023 •

edited

Loading

netlify bot commented Mar 9, 2023 •

edited

Loading